From 71d63fbe17745135968e72e8ee6d84ba9be91160 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Fran=C3=A7ois-Xavier=20Talbot?=
 <108630700+fetchfern@users.noreply.github.com>
Date: Mon, 22 Sep 2025 23:12:17 +0100
Subject: [PATCH] Fix version upload for popular projects (#4410)

* Only notify users that exist

* chore: query cache, clippy, fmt
---
 ...d0ff9f2cbc955e06268bc67eb546f9a14354fb668a0b2d2a78a.json} | 4 ++--
 apps/labrinth/src/routes/v3/version_creation.rs              | 5 +++--
 2 files changed, 5 insertions(+), 4 deletions(-)
 rename apps/labrinth/.sqlx/{query-fdfe36dcb85347a3a8228b5d5fc2d017b9baa307b5ae0ae9deaafab9dcdcb74a.json => query-c308d4eb45008d0ff9f2cbc955e06268bc67eb546f9a14354fb668a0b2d2a78a.json} (54%)

diff --git a/apps/labrinth/.sqlx/query-fdfe36dcb85347a3a8228b5d5fc2d017b9baa307b5ae0ae9deaafab9dcdcb74a.json b/apps/labrinth/.sqlx/query-c308d4eb45008d0ff9f2cbc955e06268bc67eb546f9a14354fb668a0b2d2a78a.json
similarity index 54%
rename from apps/labrinth/.sqlx/query-fdfe36dcb85347a3a8228b5d5fc2d017b9baa307b5ae0ae9deaafab9dcdcb74a.json
rename to apps/labrinth/.sqlx/query-c308d4eb45008d0ff9f2cbc955e06268bc67eb546f9a14354fb668a0b2d2a78a.json
index aba671f5..6bfc4281 100644
--- a/apps/labrinth/.sqlx/query-fdfe36dcb85347a3a8228b5d5fc2d017b9baa307b5ae0ae9deaafab9dcdcb74a.json
+++ b/apps/labrinth/.sqlx/query-c308d4eb45008d0ff9f2cbc955e06268bc67eb546f9a14354fb668a0b2d2a78a.json
@@ -1,6 +1,6 @@
 {
   "db_name": "PostgreSQL",
-  "query": "\n        SELECT follower_id FROM mod_follows\n        WHERE mod_id = $1\n        ",
+  "query": "\n        SELECT mf.follower_id FROM mod_follows mf\n        INNER JOIN users u ON u.id = follower_id\n        WHERE mf.mod_id = $1\n        ",
   "describe": {
     "columns": [
       {
@@ -18,5 +18,5 @@
       false
     ]
   },
-  "hash": "fdfe36dcb85347a3a8228b5d5fc2d017b9baa307b5ae0ae9deaafab9dcdcb74a"
+  "hash": "c308d4eb45008d0ff9f2cbc955e06268bc67eb546f9a14354fb668a0b2d2a78a"
 }
diff --git a/apps/labrinth/src/routes/v3/version_creation.rs b/apps/labrinth/src/routes/v3/version_creation.rs
index dd49340e..396395e6 100644
--- a/apps/labrinth/src/routes/v3/version_creation.rs
+++ b/apps/labrinth/src/routes/v3/version_creation.rs
@@ -400,8 +400,9 @@ async fn version_create_inner(
 
     let users = sqlx::query!(
         "
-        SELECT follower_id FROM mod_follows
-        WHERE mod_id = $1
+        SELECT mf.follower_id FROM mod_follows mf
+        INNER JOIN users u ON u.id = follower_id
+        WHERE mf.mod_id = $1
         ",
         builder.project_id as crate::database::models::ids::DBProjectId
     )