Rustic cleanups, dedups and making the code less hard to read in general (#251)

* typos :help_me:

* (part 1/?) massive cleanup to make the code more Rust-ic and cut down heap allocations.

* (part 2/?) massive cleanup to make the code more Rust-ic and cut down heap allocations.

* (part 3/?) cut down some pretty major heap allocations here - more Bytes and BytesMuts, less Vec<u8>s

also I don't really understand why you need to `to_vec` when you don't really use it again afterwards

* (part 4/?) deduplicate error handling in backblaze logic

* (part 5/?) fixes, cleanups, refactors, and reformatting

* (part 6/?) cleanups and refactors

* remove loads of `as_str` in types that already are `Display`

* Revert "remove loads of `as_str` in types that already are `Display`"

This reverts commit 4f974310cfb167ceba03001d81388db4f0fbb509.

* reformat and move routes util to the util module

* use streams

* Run prepare + formatting issues

Co-authored-by: Jai A <jaiagr+gpg@pm.me>
Co-authored-by: Geometrically <18202329+Geometrically@users.noreply.github.com>

src/search/indexing/queue.rs

@@ -16,7 +16,6 @@ impl CreationQueue {
             queue: Mutex::new(Vec::with_capacity(10)),
         }
     }
-
     pub fn add(&self, search_project: UploadSearchProject) {
         // Can only panic if mutex is poisoned
         self.queue.lock().unwrap().push(search_project);
@@ -24,12 +23,8 @@ impl CreationQueue {
     pub fn take(&self) -> Vec<UploadSearchProject> {
         std::mem::replace(&mut *self.queue.lock().unwrap(), Vec::with_capacity(10))
     }
-}
-
-pub async fn index_queue(
-    queue: &CreationQueue,
-    config: &SearchConfig,
-) -> Result<(), IndexingError> {
-    let queue = queue.take();
-    add_projects(queue, config).await
+    pub async fn index(&self, config: &SearchConfig) -> Result<(), IndexingError> {
+        let queue = self.take();
+        add_projects(queue, config).await
+    }
 }