From 94c0003c19c0ba8479b3673d343e6a5f26a1f58c Mon Sep 17 00:00:00 2001 From: Prospector <6166773+Prospector@users.noreply.github.com> Date: Thu, 13 Nov 2025 15:21:43 -0800 Subject: [PATCH] Fix a number of light mode issues and get rid of scrollbar jumping on menus (#4760) * Fix DEV-466, Fixes #4692 as well as a bunch of other poor contrast and inconsistency issues in light mode. Adds shadows to buttons and makes scrollbar gutter stable. * lintttt & only do scrollbar gutter on website * try to fix following hydration issue * try another clientonly approach * fix home page link animation * lint * remove dropdown style from checkbox & improve shadow consistency * liiiint --- apps/app-frontend/src/App.vue | 2 +- .../src/components/ui/AccountsCard.vue | 4 +- .../src/components/ui/ContextMenu.vue | 4 +- .../components/ui/InstanceCreationModal.vue | 10 +- .../components/ui/QuickInstanceSwitcher.vue | 2 +- .../src/components/ui/RunningAppBar.vue | 6 +- .../src/components/ui/world/InstanceItem.vue | 2 +- .../src/components/ui/world/WorldItem.vue | 2 +- apps/app-frontend/src/pages/Skins.vue | 2 +- .../src/assets/styles/components.scss | 4 + apps/frontend/src/assets/styles/global.scss | 3 +- apps/frontend/src/components/ui/Checkbox.vue | 151 -------- apps/frontend/src/components/ui/NavStack.vue | 4 +- .../ui/OrganizationProjectTransferModal.vue | 2 +- .../src/components/ui/charts/Chart.client.vue | 4 +- .../src/components/ui/charts/ChartDisplay.vue | 4 +- .../ui/charts/CompactChart.client.vue | 6 +- .../src/components/ui/search/SearchFilter.vue | 77 ---- .../ui/servers/ContentVersionEditModal.vue | 11 +- .../ui/servers/TeleportOverflowMenu.vue | 11 +- .../ui/thread/ConversationThread.vue | 9 +- apps/frontend/src/layouts/default.vue | 13 +- apps/frontend/src/pages/[type]/[id].vue | 160 ++++---- .../src/pages/[type]/[id]/settings/tags.vue | 7 +- .../frontend/src/pages/dashboard/projects.vue | 14 +- .../src/pages/dashboard/revenue/index.vue | 6 +- .../organization/[id]/settings/projects.vue | 352 +++++++++--------- apps/frontend/src/pages/report.vue | 2 +- .../src/pages/search/[searchProjectType].vue | 12 +- packages/assets/styles/classes.scss | 4 +- packages/assets/styles/highlightjs.scss | 2 +- packages/assets/styles/variables.scss | 8 +- .../ui/src/components/base/ButtonStyled.vue | 19 +- packages/ui/src/components/base/Checkbox.vue | 130 ++----- .../ui/src/components/base/MarkdownEditor.vue | 2 +- .../ui/src/components/base/OverflowMenu.vue | 2 +- packages/ui/src/components/chart/Chart.vue | 4 +- .../ui/src/components/chart/CompactChart.vue | 6 +- packages/ui/src/components/modal/NewModal.vue | 12 - .../project/ProjectPageVersions.vue | 2 +- 40 files changed, 384 insertions(+), 693 deletions(-) delete mode 100644 apps/frontend/src/components/ui/Checkbox.vue delete mode 100644 apps/frontend/src/components/ui/search/SearchFilter.vue diff --git a/apps/app-frontend/src/App.vue b/apps/app-frontend/src/App.vue index 79243c3c..6eda2bc5 100644 --- a/apps/app-frontend/src/App.vue +++ b/apps/app-frontend/src/App.vue @@ -765,7 +765,7 @@ provideAppUpdateDownloadProgress(appUpdateDownload) > -
+
diff --git a/apps/app-frontend/src/components/ui/AccountsCard.vue b/apps/app-frontend/src/components/ui/AccountsCard.vue index 54f0c510..493ce451 100644 --- a/apps/app-frontend/src/components/ui/AccountsCard.vue +++ b/apps/app-frontend/src/components/ui/AccountsCard.vue @@ -284,7 +284,7 @@ onUnmounted(() => { z-index: 11; gap: 0.5rem; padding: 1rem; - border: 1px solid var(--color-button-bg); + border: 1px solid var(--color-divider); width: max-content; user-select: none; -ms-user-select: none; @@ -380,7 +380,7 @@ onUnmounted(() => { text-align: left; &.expanded { - border: 1px solid var(--color-button-bg); + border: 1px solid var(--color-divider); padding: 1rem; } } diff --git a/apps/app-frontend/src/components/ui/ContextMenu.vue b/apps/app-frontend/src/components/ui/ContextMenu.vue index c858eaa3..e778190f 100644 --- a/apps/app-frontend/src/components/ui/ContextMenu.vue +++ b/apps/app-frontend/src/components/ui/ContextMenu.vue @@ -119,7 +119,7 @@ onBeforeUnmount(() => { background-color: var(--color-raised-bg); border-radius: var(--radius-md); box-shadow: var(--shadow-floating); - border: 1px solid var(--color-button-bg); + border: 1px solid var(--color-divider); margin: 0; position: fixed; z-index: 1000000; @@ -163,7 +163,7 @@ onBeforeUnmount(() => { } .divider { - border: 1px solid var(--color-button-bg); + border: 1px solid var(--color-divider); margin: var(--gap-sm); pointer-events: none; } diff --git a/apps/app-frontend/src/components/ui/InstanceCreationModal.vue b/apps/app-frontend/src/components/ui/InstanceCreationModal.vue index 29fb8687..83dee767 100644 --- a/apps/app-frontend/src/components/ui/InstanceCreationModal.vue +++ b/apps/app-frontend/src/components/ui/InstanceCreationModal.vue @@ -34,7 +34,7 @@

Game version

-
+
- +
@@ -546,12 +546,6 @@ const next = async () => { font-style: italic; } -.versions { - display: flex; - flex-direction: row; - gap: 1rem; -} - :deep(button.checkbox) { border: none; } diff --git a/apps/app-frontend/src/components/ui/QuickInstanceSwitcher.vue b/apps/app-frontend/src/components/ui/QuickInstanceSwitcher.vue index 64e5bd26..7186203c 100644 --- a/apps/app-frontend/src/components/ui/QuickInstanceSwitcher.vue +++ b/apps/app-frontend/src/components/ui/QuickInstanceSwitcher.vue @@ -69,7 +69,7 @@ onUnmounted(() => {
-
+
diff --git a/apps/app-frontend/src/components/ui/RunningAppBar.vue b/apps/app-frontend/src/components/ui/RunningAppBar.vue index 38194119..53f05036 100644 --- a/apps/app-frontend/src/components/ui/RunningAppBar.vue +++ b/apps/app-frontend/src/components/ui/RunningAppBar.vue @@ -293,7 +293,7 @@ onBeforeUnmount(() => { align-items: center; gap: 0.5rem; border-radius: var(--radius-md); - border: 1px solid var(--color-button-bg); + border: 1px solid var(--color-divider); padding: var(--gap-sm) var(--gap-lg); } @@ -356,7 +356,7 @@ onBeforeUnmount(() => { gap: 1rem; overflow: auto; transition: all 0.2s ease-in-out; - border: 1px solid var(--color-button-bg); + border: 1px solid var(--color-divider); &.hidden { transform: translateY(-100%); @@ -454,7 +454,7 @@ onBeforeUnmount(() => { flex-direction: column; overflow: auto; transition: all 0.2s ease-in-out; - border: 1px solid var(--color-button-bg); + border: 1px solid var(--color-divider); padding: var(--gap-md); &.hidden { diff --git a/apps/app-frontend/src/components/ui/world/InstanceItem.vue b/apps/app-frontend/src/components/ui/world/InstanceItem.vue index f03f11cd..61fa1f9d 100644 --- a/apps/app-frontend/src/components/ui/world/InstanceItem.vue +++ b/apps/app-frontend/src/components/ui/world/InstanceItem.vue @@ -130,7 +130,7 @@ onUnmounted(() => { />
- - - - - - diff --git a/apps/frontend/src/components/ui/NavStack.vue b/apps/frontend/src/components/ui/NavStack.vue index 43d1188e..24f183dc 100644 --- a/apps/frontend/src/components/ui/NavStack.vue +++ b/apps/frontend/src/components/ui/NavStack.vue @@ -1,6 +1,8 @@