fix: malformed versions causing versions list page to crash (#6315)

apps/frontend/src/pages/[type]/[project].vue

@@ -1874,12 +1874,18 @@ const isSettings = computed(() => route.name.startsWith('type-project-settings')
 
 // Transform versionsV3 to be same shape as versionsV2 for compatibility in project pages
 const versionsRaw = computed(() => {
-	return (versionsV3.value ?? []).map((v) => {
-		const isModpack = v.project_types?.includes('modpack')
+	return (versionsV3.value ?? []).map((version) => {
+		const files = Array.isArray(version.files) ? version.files : []
+		const gameVersions = Array.isArray(version.game_versions) ? version.game_versions : []
+		const loaders = Array.isArray(version.loaders) ? version.loaders : []
+		const isModpack = version.project_types?.includes('modpack')
+		const mrpackLoaders = Array.isArray(version.mrpack_loaders) ? version.mrpack_loaders : []
 
 		return {
-			...v,
-			loaders: isModpack && v.mrpack_loaders ? v.mrpack_loaders : v.loaders,
+			...version,
+			files,
+			game_versions: gameVersions,
+			loaders: isModpack && mrpackLoaders.length ? mrpackLoaders : loaders,
 		}
 	})
 })

apps/frontend/src/pages/[type]/[project]/changelog.vue

@@ -53,11 +53,11 @@
 										{{ formatDate(version.date_published) }}</span
 									>
 								</div>
-								<ButtonStyled color="brand" type="transparent">
+								<ButtonStyled v-if="getPrimaryFile(version)" color="brand" type="transparent">
 									<a
 										class="ml-auto"
 										:href="createDownloadUrl(version)"
-										:download="getPrimaryFile(version).filename"
+										:download="getPrimaryFile(version)?.filename"
 										:title="`Download ${version.name}`"
 									>
 										<DownloadIcon aria-hidden="true" />
@@ -145,10 +145,10 @@ const filteredVersions = computed(() => {
 		(projectVersion) =>
 			(selectedGameVersions.length === 0 ||
 				selectedGameVersions.some((gameVersion) =>
-					projectVersion.game_versions.includes(gameVersion),
+					getVersionGameVersions(projectVersion).includes(gameVersion),
 				)) &&
 			(selectedLoaders.length === 0 ||
-				selectedLoaders.some((loader) => projectVersion.loaders.includes(loader))) &&
+				selectedLoaders.some((loader) => getVersionLoaders(projectVersion).includes(loader))) &&
 			(selectedVersionTypes.length === 0 ||
 				selectedVersionTypes.includes(projectVersion.version_type)),
 	)
@@ -233,14 +233,25 @@ watch(
 )
 
 function getPrimaryFile(version) {
-	return version.files.find((x) => x.primary) || version.files[0]
+	return version.files?.find((x) => x.primary) || version.files?.[0]
 }
 
 function createDownloadUrl(version) {
-	return createProjectDownloadUrl(getPrimaryFile(version).url, {
+	const file = getPrimaryFile(version)
+	if (!file?.url) return undefined
+
+	return createProjectDownloadUrl(file.url, {
 		reason: cdnDownloadReason.value,
 	})
 }
+
+function getVersionGameVersions(version) {
+	return Array.isArray(version.game_versions) ? version.game_versions : []
+}
+
+function getVersionLoaders(version) {
+	return Array.isArray(version.loaders) ? version.loaders : []
+}
 </script>
 
 <style lang="scss">

apps/frontend/src/pages/[type]/[project]/settings/versions.vue

@@ -111,10 +111,11 @@
 								color: 'primary',
 								hoverFilled: true,
 								link: createDownloadUrl(version),
-								download: getPrimaryFile(version).filename,
+								download: getPrimaryFile(version)?.filename,
 								action: () => {
 									emit('onDownload')
 								},
+								shown: !!getPrimaryFile(version),
 							},
 							{
 								id: 'new-tab',
@@ -402,7 +403,7 @@ const emit = defineEmits(['onDownload'])
 const baseDropdownId = useId()
 
 function getPrimaryFile(version: Labrinth.Versions.v3.Version) {
-	return version.files.find((x) => x.primary) || version.files[0]
+	return version.files?.find((x) => x.primary) || version.files?.[0]
 }
 
 watch(
@@ -417,7 +418,10 @@ watch(
 )
 
 function createDownloadUrl(version: Labrinth.Versions.v3.Version) {
-	return createProjectDownloadUrl(getPrimaryFile(version).url, {
+	const file = getPrimaryFile(version)
+	if (!file?.url) return undefined
+
+	return createProjectDownloadUrl(file.url, {
 		reason: cdnDownloadReason.value,
 	})
 }

apps/frontend/src/pages/[type]/[project]/versions.vue

@@ -43,11 +43,11 @@
 				:open-modal="currentMember ? () => handleOpenCreateVersionModal() : undefined"
 			>
 				<template #actions="{ version }">
-					<ButtonStyled circular type="transparent">
+					<ButtonStyled v-if="getPrimaryFile(version)" circular type="transparent">
 						<a
 							v-tooltip="`Download`"
 							:href="createDownloadUrl(version)"
-							:download="getPrimaryFile(version).filename"
+							:download="getPrimaryFile(version)?.filename"
 							class="hover:!bg-button-bg [&>svg]:!text-green"
 							aria-label="Download"
 							@click="emit('onDownload')"
@@ -102,10 +102,11 @@
 									color: 'primary',
 									hoverFilled: true,
 									link: createDownloadUrl(version),
-									download: getPrimaryFile(version).filename,
+									download: getPrimaryFile(version)?.filename,
 									action: () => {
 										emit('onDownload')
 									},
+									shown: !!getPrimaryFile(version),
 								},
 								{
 									id: 'new-tab',
@@ -318,7 +319,7 @@ const emit = defineEmits(['onDownload', 'deleteVersion'])
 const baseDropdownId = useId()
 
 function getPrimaryFile(version) {
-	return version.files.find((x) => x.primary) || version.files[0]
+	return version.files?.find((x) => x.primary) || version.files?.[0]
 }
 
 watch(
@@ -333,7 +334,10 @@ watch(
 )
 
 function createDownloadUrl(version) {
-	return createProjectDownloadUrl(getPrimaryFile(version).url, {
+	const file = getPrimaryFile(version)
+	if (!file?.url) return undefined
+
+	return createProjectDownloadUrl(file.url, {
 		reason: cdnDownloadReason.value,
 	})
 }