fix: make insufficient gallery images checklist item always show (#3692)

* fix(moderation): make insufficient gallery images checklist item always show

* fix(moderation): Make gallery ordering more consistent

apps/frontend/src/components/ui/ModerationChecklist.vue

@@ -256,7 +256,9 @@
         </p>
         <div class="options input-group">
           <button
-            v-for="(option, index) in steps[currentStepIndex].options"
+            v-for="(option, index) in steps[currentStepIndex].options.filter(
+              (x) => x.shown !== false,
+            )"
             :key="index"
             class="btn"
             :class="{
@@ -646,22 +648,23 @@ For a brief rundown of how this works:
     {
       id: "gallery",
       navigate: `/${props.project.project_type}/${props.project.slug}/gallery`,
-      question: `Are the project's gallery images relevant?`,
+      question: `Are this project's gallery images sufficient?`,
-      shown: props.project.gallery.length > 0,
+      shown: true,
       options: [
         {
-          name: "Not relevant",
+          name: "Insufficient",
-          resultingMessage: `## Unrelated Gallery Images
+          resultingMessage: `## Insufficient Gallery Images
-Per section 5.5 of [Modrinth's Content Rules](https://modrinth.com/legal/rules#miscellaneous) any images in your project's Gallery must be relevant to the project and also include a Title.`,
+        We ask that projects like yours show off their content using images in the Gallery, or optionally in the Description, in order to effectively and clearly inform users of its content per section 2.1 of [Modrinth's content rules](https://modrinth.com/legal/rules#general-expectations).
+        Keep in mind that you should:
+        - Set a featured image that best represents your project.
+        - Ensure all your images have titles that accurately label the image, and optionally, details on the contents of the image in the images Description.
+        - Upload any relevant images in your Description to your Gallery tab for best results.`,
         },
         {
-          name: "Insufficient images",
+          name: "Not relevant",
-          resultingMessage: `## Insufficient Gallery Images
+          shown: props.project.gallery.length > 0,
-We ask that projects like yours show off their content using images in the Gallery, or optionally in the Description, in order to effectively and clearly inform users of its content per section 2.1 of [Modrinth's content rules](https://modrinth.com/legal/rules#general-expectations).
+          resultingMessage: `## Unrelated Gallery Images
-Keep in mind that you should:
+Per section 5.5 of [Modrinth's Content Rules](https://modrinth.com/legal/rules#miscellaneous) any images in your project's Gallery must be relevant to the project and also include a Title.`,
-- Set a featured image that best represents your project.
-- Ensure all your images have titles that accurately label the image, and optionally, details on the contents of the image in the images Description.
-- Upload any relevant images in your Description to your Gallery tab for best results.`,
         },
       ],
     },