eightequal/AstralRinth
1
0
Fork 0
forked from didirus/AstralRinth
Code Pull Requests Activity

Fixes failing tests (#813)

Browse Source 
* fixes failing  tests

* fmt clippy

* updated dockerfile

* fixes failing tests; adds important fix from extracts_versions PR

* assert_eq -> assert_status, giving better error messages

* fixed random failure bug

* fmt, clippy, etc
This commit is contained in:
Wyatt Verchere
2024-01-05 08:20:56 -08:00
committed by GitHub
parent f5802fee31
commit 10eed05d87
37 changed files with 555 additions and 330 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
tests/common/permissions.rs
View File

@@ -356,12 +356,13 @@ impl<'a, A: Api> PermissionsTest<'a, A> {
.await;
if !self.allowed_failure_codes.contains(&resp.status().as_u16()) {
return Err(format!(
"Failure permissions test failed. Expected failure codes {} got {}",
"Failure permissions test failed. Expected failure codes {} got {}. Body: {:#?}",
self.allowed_failure_codes
.iter()
.map(|code| code.to_string())
.join(","),
resp.status().as_u16()
resp.status().as_u16(),
resp.response().body()
));
}
@@ -385,8 +386,9 @@ impl<'a, A: Api> PermissionsTest<'a, A> {
.await;
if !resp.status().is_success() {
return Err(format!(
"Success permissions test failed. Expected success, got {}",
resp.status().as_u16()
"Success permissions test failed. Expected success, got {}. Body: {:#?}",
resp.status().as_u16(),
resp.response().body()
));
}
@@ -1007,15 +1009,15 @@ async fn create_dummy_project(setup_api: &ApiV3) -> (String, String) {
async fn create_dummy_org(setup_api: &ApiV3) -> (String, String) {
// Create a very simple organization
let name = generate_random_name("test_org");
let slug = generate_random_name("test_org");
let resp = setup_api
.create_organization(&name, "Example description.", ADMIN_USER_PAT)
.create_organization("Example org", &slug, "Example description.", ADMIN_USER_PAT)
.await;
assert!(resp.status().is_success());
let organization = setup_api
.get_organization_deserialized(&name, ADMIN_USER_PAT)
.get_organization_deserialized(&slug, ADMIN_USER_PAT)
.await;
let organizaion_id = organization.id.to_string();
let team_id = organization.team_id.to_string();
@@ -1109,7 +1111,7 @@ async fn get_project_permissions(
.await;
let permissions = members
.iter()
.find(|member| &member.user.id.to_string() == user_id)
.find(|member| member.user.id.to_string() == user_id)
.and_then(|member| member.permissions);
let organization_members = match organization {
@@ -1123,7 +1125,7 @@ async fn get_project_permissions(
let organization_default_project_permissions = match organization_members {
Some(members) => members
.iter()
.find(|member| &member.user.id.to_string() == user_id)
.find(|member| member.user.id.to_string() == user_id)
.and_then(|member| member.permissions),
None => None,
};