Rustic cleanups, dedups and making the code less hard to read in general (#251)

* typos :help_me:

* (part 1/?) massive cleanup to make the code more Rust-ic and cut down heap allocations.

* (part 2/?) massive cleanup to make the code more Rust-ic and cut down heap allocations.

* (part 3/?) cut down some pretty major heap allocations here - more Bytes and BytesMuts, less Vec<u8>s

also I don't really understand why you need to `to_vec` when you don't really use it again afterwards

* (part 4/?) deduplicate error handling in backblaze logic

* (part 5/?) fixes, cleanups, refactors, and reformatting

* (part 6/?) cleanups and refactors

* remove loads of `as_str` in types that already are `Display`

* Revert "remove loads of `as_str` in types that already are `Display`"

This reverts commit 4f974310cfb167ceba03001d81388db4f0fbb509.

* reformat and move routes util to the util module

* use streams

* Run prepare + formatting issues

Co-authored-by: Jai A <jaiagr+gpg@pm.me>
Co-authored-by: Geometrically <18202329+Geometrically@users.noreply.github.com>
This commit is contained in:
Leo Chen
2021-10-12 11:26:59 +08:00
committed by GitHub
parent 0010119440
commit 13187de97d
53 changed files with 997 additions and 1129 deletions

View File

@@ -15,7 +15,7 @@ struct DiscordEmbed {
#[derive(Serialize)]
struct DiscordEmbedField {
pub name: String,
pub name: &'static str,
pub value: String,
pub inline: bool,
}
@@ -36,36 +36,36 @@ pub async fn send_discord_webhook(
) -> Result<(), reqwest::Error> {
let mut fields = vec![
DiscordEmbedField {
name: "id".to_string(),
name: "id",
value: project.id.to_string(),
inline: true,
},
DiscordEmbedField {
name: "project_type".to_string(),
value: project.project_type.to_string(),
name: "project_type",
value: project.project_type.clone(),
inline: true,
},
DiscordEmbedField {
name: "client_side".to_string(),
name: "client_side",
value: project.client_side.to_string(),
inline: true,
},
DiscordEmbedField {
name: "server_side".to_string(),
name: "server_side",
value: project.server_side.to_string(),
inline: true,
},
DiscordEmbedField {
name: "categories".to_string(),
name: "categories",
value: project.categories.join(", "),
inline: true,
},
];
if let Some(slug) = project.slug.clone() {
if let Some(ref slug) = project.slug {
fields.push(DiscordEmbedField {
name: "slug".to_string(),
value: slug,
name: "slug",
value: slug.clone(),
inline: true,
});
}
@@ -82,7 +82,7 @@ pub async fn send_discord_webhook(
title: project.title,
description: project.description,
timestamp: project.published,
color: 6137157,
color: 0x5DA545,
fields,
image: DiscordEmbedImage {
url: project.icon_url,