Bug fixes round 3 (#298)

* fixed bugs

* title case

* bugs; ioerror

* reset breadcrumbs

* more fixes

* more fixes

* scrolling bug

* more fixes

* more fixes

* clippy

* canonicalize fix

* fixed requested changes

* removed debouncer update
This commit is contained in:
Wyatt Verchere
2023-07-19 14:13:25 -07:00
committed by GitHub
parent 6650cc9ce4
commit 1f478ec9fc
34 changed files with 932 additions and 602 deletions

View File

@@ -122,9 +122,9 @@
</div>
<Chips
v-model="javaSelectionType"
:items="['automatically install', 'use existing installation']"
:items="['Automatically install', 'Use existing installation']"
/>
<div v-if="javaSelectionType === 'use existing installation'" class="settings-group">
<div v-if="javaSelectionType === 'Use existing installation'" class="settings-group">
<h3>Java location</h3>
<JavaSelector v-model="settings.java_globals.JAVA_17" compact />
</div>
@@ -230,7 +230,7 @@ async function pageTurn() {
}
}
const javaSelectionType = ref('automatically install')
const javaSelectionType = ref('Automatically install')
async function autoInstallJava() {
const path = await auto_install_java(17).catch(handleError)
@@ -239,6 +239,7 @@ async function autoInstallJava() {
// weird vue bug, ignore
settings.value.java_globals.JAVA_17 = version
settings.value.java_globals.JAVA_17 = version
set(settings.value)
mixpanel.track('OnboardingAutoInstallJava')
}
@@ -258,6 +259,10 @@ onBeforeUnmount(() => {
</script>
<style scoped lang="scss">
:deep(.chips .btn) {
text-transform: none !important;
}
.modal-body {
display: flex;
flex-direction: column;

View File

@@ -1,5 +1,6 @@
<template>
<div class="breadcrumbs">
{{ breadcrumbData.resetToNames(breadcrumbs) }}
<div v-for="breadcrumb in breadcrumbs" :key="breadcrumb.name" class="breadcrumbs__item">
<router-link
v-if="breadcrumb.link"

View File

@@ -40,7 +40,7 @@
</div>
<div v-else class="status">
<span class="circle stopped" />
<span class="running-text"> No running instances </span>
<span class="running-text"> No instances running </span>
</div>
</div>
<transition name="download">

View File

@@ -14,6 +14,7 @@ defineProps({
<style scoped lang="scss">
.page-loading {
position: relative;
display: flex;
flex-direction: column;
justify-content: center;