Fix #485 by removing default loader from version filters (#487)

* Fix #485 by removing default loader from version filters

It's really not our place to be imposing a default loader on people, especially as we start adding more loaders

* Fix Clear Filters button and capitalise loaders
This commit is contained in:
Emma C. Pointer-Null
2022-05-24 00:38:08 -04:00
committed by GitHub
parent afaa235c75
commit 21df0e32c4

View File

@@ -6,7 +6,9 @@
<Multiselect <Multiselect
v-if="getValidLoaders().length > 1" v-if="getValidLoaders().length > 1"
v-model="selectedLoader" v-model="selectedLoader"
:options="getValidLoaders()" :options="
getValidLoaders().map((x) => x.charAt(0).toUpperCase() + x.slice(1))
"
:multiple="false" :multiple="false"
:searchable="false" :searchable="false"
:show-no-results="false" :show-no-results="false"
@@ -50,13 +52,10 @@
/> />
<button <button
title="Clear filters" title="Clear filters"
:disabled=" :disabled="selectedLoader === null && selectedGameVersions.length === 0"
selectedLoader === getDefaultLoader() &&
selectedGameVersions.length === 0
"
class="iconified-button" class="iconified-button"
@click=" @click="
selectedLoader = getDefaultLoader() selectedLoader = null
selectedGameVersions = [] selectedGameVersions = []
updateVersionFilters() updateVersionFilters()
" "
@@ -92,18 +91,10 @@ export default {
cachedValidVersions: null, cachedValidVersions: null,
cachedValidLoaders: null, cachedValidLoaders: null,
selectedGameVersions: [], selectedGameVersions: [],
selectedLoader: this.getDefaultLoader(), selectedLoader: null,
} }
}, },
methods: { methods: {
getDefaultLoader() {
const loaders = this.getValidLoaders()
if (loaders.includes('fabric')) {
return 'fabric'
} else {
return loaders[0]
}
},
getValidVersions() { getValidVersions() {
if (!this.cachedValidVersions) { if (!this.cachedValidVersions) {
this.cachedValidVersions = this.$tag.gameVersions.filter((gameVer) => this.cachedValidVersions = this.$tag.gameVersions.filter((gameVer) =>
@@ -132,9 +123,9 @@ export default {
(projectVersion) => (projectVersion) =>
(this.selectedGameVersions.length === 0 || (this.selectedGameVersions.length === 0 ||
this.selectedGameVersions.some((gameVersion) => this.selectedGameVersions.some((gameVersion) =>
projectVersion.game_versions.includes(gameVersion) projectVersion.game_versions.includes(gameVersion.toLowerCase())
)) && )) &&
projectVersion.loaders.includes(this.selectedLoader) projectVersion.loaders.includes(this.selectedLoader.toLowerCase())
) )
this.$emit('updateVersions', temp) this.$emit('updateVersions', temp)
}, },