From 3535f0c4b4d06b27a74a4b011e6c83857a50d636 Mon Sep 17 00:00:00 2001 From: Geometrically <18202329+Geometrically@users.noreply.github.com> Date: Sun, 11 Jun 2023 15:26:25 -0700 Subject: [PATCH] Search fixes (#134) * Search fixes * Fix small instance ui * fix javaw issue * menu fix * Add confirm modal for deletion * fix build --- theseus/src/api/jre.rs | 2 +- theseus/src/event/emit.rs | 2 +- theseus/src/event/mod.rs | 78 +- theseus_gui/package.json | 2 +- theseus_gui/pnpm-lock.yaml | 8 +- theseus_gui/src-tauri/icons/32x32.png | Bin 2518 -> 0 bytes theseus_gui/src-tauri/tauri.conf.json | 1 - .../src/components/ui/AccountsCard.vue | 6 +- theseus_gui/src/components/ui/Breadcrumbs.vue | 5 +- theseus_gui/src/components/ui/Instance.vue | 162 +--- .../src/components/ui/JavaDetectionModal.vue | 2 - .../src/components/ui/RunningAppBar.vue | 6 +- theseus_gui/src/components/ui/SearchCard.vue | 19 +- theseus_gui/src/helpers/process.js | 4 +- theseus_gui/src/pages/Browse.vue | 720 +++++++++++++----- theseus_gui/src/pages/Index.vue | 1 - theseus_gui/src/pages/Settings.vue | 71 +- theseus_gui/src/pages/instance/Index.vue | 8 +- theseus_gui/src/pages/instance/Logs.vue | 33 +- theseus_gui/src/pages/instance/Mods.vue | 8 +- theseus_gui/src/pages/instance/Options.vue | 35 +- theseus_gui/src/pages/project/Index.vue | 70 +- theseus_gui/src/store/search.js | 126 --- theseus_gui/src/store/state.js | 3 +- 24 files changed, 796 insertions(+), 576 deletions(-) delete mode 100644 theseus_gui/src-tauri/icons/32x32.png delete mode 100644 theseus_gui/src/store/search.js diff --git a/theseus/src/api/jre.rs b/theseus/src/api/jre.rs index 36c273c7..f8ac91fd 100644 --- a/theseus/src/api/jre.rs +++ b/theseus/src/api/jre.rs @@ -156,7 +156,7 @@ pub async fn auto_install_java(java_version: u32) -> crate::Result { "Failed to extract java zip".to_string(), )) })?; - emit_loading(&loading_bar, 100.0, Some("Done extracting java")).await?; + emit_loading(&loading_bar, 10.0, Some("Done extracting java")).await?; Ok(path .join( download diff --git a/theseus/src/event/emit.rs b/theseus/src/event/emit.rs index 80d1a60d..9b4d1d93 100644 --- a/theseus/src/event/emit.rs +++ b/theseus/src/event/emit.rs @@ -175,7 +175,7 @@ pub async fn emit_loading( ); } - // Emit event to tauri + //Emit event to tauri #[cfg(feature = "tauri")] event_state .app diff --git a/theseus/src/event/mod.rs b/theseus/src/event/mod.rs index 997f2922..deae448f 100644 --- a/theseus/src/event/mod.rs +++ b/theseus/src/event/mod.rs @@ -94,51 +94,43 @@ impl Drop for LoadingBarId { let _event = LoadingBarType::StateInit; let _message = "finished".to_string(); tokio::spawn(async move { - if let Ok(event_state) = crate::EventState::get().await { - { - let mut bars = event_state.loading_bars.write().await; - bars.remove(&loader_uuid); + if let Ok(event_state) = EventState::get().await { + let mut bars = event_state.loading_bars.write().await; + + #[cfg(any(feature = "tauri", feature = "cli"))] + if let Some(bar) = bars.remove(&loader_uuid) { + #[cfg(feature = "tauri")] + { + let loader_uuid = bar.loading_bar_uuid; + let event = bar.bar_type.clone(); + let fraction = bar.current / bar.total; + + use tauri::Manager; + let _ = event_state.app.emit_all( + "loading", + LoadingPayload { + fraction: None, + message: "Completed".to_string(), + event, + loader_uuid, + }, + ); + tracing::debug!( + "Exited at {fraction} for loading bar: {:?}", + loader_uuid + ); + } + + // Emit event to indicatif progress bar arc + #[cfg(feature = "cli")] + { + let cli_progress_bar = bar.cli_progress_bar.clone(); + cli_progress_bar.finish(); + } } - } - }); - } -} -// When Loading bar is dropped, should attempt to throw out one last event to indicate that the loading bar is done -#[cfg(feature = "tauri")] -impl Drop for LoadingBar { - fn drop(&mut self) { - let loader_uuid = self.loading_bar_uuid; - let event = self.bar_type.clone(); - let fraction = self.current / self.total; - - #[cfg(feature = "cli")] - let cli_progress_bar = self.cli_progress_bar.clone(); - - tokio::spawn(async move { - #[cfg(feature = "tauri")] - { - use tauri::Manager; - if let Ok(event_state) = crate::EventState::get().await { - let _ = event_state.app.emit_all( - "loading", - LoadingPayload { - fraction: None, - message: "Completed".to_string(), - event, - loader_uuid, - }, - ); - tracing::debug!( - "Exited at {fraction} for loading bar: {:?}", - loader_uuid - ); - } - } - // Emit event to indicatif progress bar arc - #[cfg(feature = "cli")] - { - cli_progress_bar.finish(); + #[cfg(not(any(feature = "tauri", feature = "cli")))] + bars.remove(&loader_uuid); } }); } diff --git a/theseus_gui/package.json b/theseus_gui/package.json index 721736aa..afa75149 100644 --- a/theseus_gui/package.json +++ b/theseus_gui/package.json @@ -17,7 +17,7 @@ "dayjs": "^1.11.7", "floating-vue": "^2.0.0-beta.20", "ofetch": "^1.0.1", - "omorphia": "^0.4.22", + "omorphia": "^0.4.24", "pinia": "^2.1.3", "vite-svg-loader": "^4.0.0", "vue": "^3.3.4", diff --git a/theseus_gui/pnpm-lock.yaml b/theseus_gui/pnpm-lock.yaml index aeab6b92..de5732e9 100644 --- a/theseus_gui/pnpm-lock.yaml +++ b/theseus_gui/pnpm-lock.yaml @@ -14,8 +14,8 @@ dependencies: specifier: ^1.0.1 version: 1.0.1 omorphia: - specifier: ^0.4.22 - version: 0.4.22 + specifier: ^0.4.24 + version: 0.4.24 pinia: specifier: ^2.1.3 version: 2.1.3(vue@3.3.4) @@ -1326,8 +1326,8 @@ packages: ufo: 1.1.2 dev: false - /omorphia@0.4.22: - resolution: {integrity: sha512-UzG/MqOu/q+F65RZ74oCOLHE4dm716cCkX9EtSP30s8RInd8AHuax4riFKK+ANfCCtE9zcDw4AmU7fJlUnX6Xw==} + /omorphia@0.4.24: + resolution: {integrity: sha512-tYhg88wkv9yfCNF8uVDkt6MIZ5WuCEezWrWJuBpHXP0X1yNGey6ICbH0LSuNuOMtqhGJEIupGEB7uV4Db9b7uQ==} dependencies: dayjs: 1.11.7 floating-vue: 2.0.0-beta.20(vue@3.3.4) diff --git a/theseus_gui/src-tauri/icons/32x32.png b/theseus_gui/src-tauri/icons/32x32.png deleted file mode 100644 index 1bd35561abae6916a68e944cb4494d716d2f0a8f..0000000000000000000000000000000000000000 GIT binary patch literal 0 HcmV?d00001 literal 2518 zcmV;{2`To8P)2%6Wq0mC1`vOv^1*z7?NMj5!5JWU4Bn=`6p=iX$B_TFKYlAi> z5@WSd8sic*g-DBtq$#ZwyUlc`bendjGo9tl%$qmw-FuGTf8LwgR*K~{H|e~0&-u6S z|Nie+xbjEwF?=HVLu=EVOr@43lBuOZA~8oB)1s8h%5ToOVH?M1qGEARakTK-Xrb_m zwQ*PFo`6p*uU*N=2YpQC5P~3_mdRGHNM_Ra(TO?~E!-%5ik(=l+`?;&hD!2SLW9Qp zM)MU4F@Q<`>cZj@K37_C{TDK%QPWEE->WhZha zxQ=1x-W#wulb2YHu1>%zhkS1E$3uhtD=HZnyZed`_!o=`Cf7BL+Z3jf)9e5ZCrzZ6 zv>N@{>y(<&05qk5bO2?_$6aKB5e9c|1a4n1>?(*Q-Iu0&(!N8!3hfT2?PB%@X1=~P1! zD$sDl5!}DK5x>~x?2fLIu1_V1k-@&6b023(_Fe3Ry0|_Pc|%k4UafT24wp*7qccLi zd>WA9`y;$`M>p*2r+t*JD_@RUGMi*JuE{{nZG`^xM5x=EfRynL#y@F8{L6zSU6Tl{ zwS&FgU9*^p6Js`2#R=Y`Ok-1XTM#C0u|vgD@SXXg{_<4%Nzff0;6?l3wsyh|6w9d- z1M)CpU)^Eipb$gVC!s&l0{z5HsL9ntl7jvD0Yq!|lyq$}ER7c1dV4x&S1_SWB^{Q4 zTbruNE|ateU!R%K%clcOw?rI2^)|q$eLG5&58Md-rKvCvPo;DH!0|z-*^N*w8K7er z?npn+bwE$4g_>9ebvrXM92vWN2e5&Y30ies z74-Zj;-W{p6FC)Dr56@P@*ADC-QobMYU-X(go(M%5QM817~d zTLk^d7WO%h9LvFO>45#~3AmlzP?3ZF{PobcHbK!bJ#QTBHu6w^5d9CM)+Qs2R$bq)4!L4VFPo(F7jIHvE#vR+1ls!`eINYnE~uMofq@e2ORVQ} zyWsx#K8vr4v2v#=kfSyNTVCB;_)t!MEo@m{6j!d(R_!;B`72!v5+I(a#KgWh(UN zCLyp6YFZuCwOJp8lqVLj_7=g}vQ*1p5uD3`lZjMIi+?&F7D_6?C*~evkGeA z1OzYK;X#So1RU`Yui9143NwakI`Nw$Ku^K{t{Du*z}Iy;3%fnKJ(Z>D@a@g)o?Z_+$(sJmwXjD95PfSq6xmeYKLwfrv2;p? z7{_^)w1X8RJ~h)hXeL!(I-bU+xH!V7q&?+3AtV`0u4{zt*^2OYOAu~Y?91i~r3%SA z-yw>nxG*`(0%GiT9XO4=8i=a&eUpj!d2oAs5iNhK9I4PQsn$nH$AXpfp@?wg%fuA? zXaOV5k^ftPI%4HeKir=4j5d^>_x7E%p}gOig5u+cS+3+Ygb0~{Q>w#gbu;VkXiTX| zq|WBF#{roOPI&!Otv;Q?XpWb;W29b|L9y4>?c>YhgzXote8&S=I77{1b_h(LG5)Tk z%tC7X=g#K6Em2VcdvQ;YOy10aW6_m2Xf9uD-|g}(>AkNBJvJ;$U^gE19buRa{os^x z)bjmbj>GNh@tr_2E2F-XLA-U=pLY~0(O2JujCFTpz*0S#s5r7aC>BOGr|L8J;}ns5 zpr6Ad%l^IIN2ZruS00*zdZx^-KZJOFJ5)m!@!GwxBrMlP(4EcuT7#{nAG(QPn@mRt zn?KX3_Xk;?M0sj<=F2*Qog#M@2Me1GXY|>0rs@$@h%=1R>3dq0)Jjq)Q9I#uLG1W6 zfj5rPq&&i<&)vTBp6#UHrE@4;U>=>p;S%~85kL2CnHkBJ!A}>l|EuM!BiB&nxxT?% z|2GVQFcbvA)I>Hj&%QSh>$_XDYD{`!iPut0e3y0IO+$B(N;#y2W<9TyBZL=x+meRm zac_>>YN0Z%GBl2#cv{^`6(=c9wx4a{pw_cbqHN zyqCK0?1)dXrBSKBOh@qle}?ZL*m0@X48q1sZX2Xf!rEK|1vzeUyx*=B%830 zl5ConWGgAj9-B#TCi z?dN+sXN^g+4;Q6htB6veW$AxL?AH4K(gPQZ(%BVx zenFI8Cd(6);U4zv!&d?38Selected

@@ -54,7 +54,7 @@ diff --git a/theseus_gui/src/components/ui/SearchCard.vue b/theseus_gui/src/components/ui/SearchCard.vue index 46c8bff2..480b0716 100644 --- a/theseus_gui/src/components/ui/SearchCard.vue +++ b/theseus_gui/src/components/ui/SearchCard.vue @@ -1,5 +1,13 @@