Fixes incorrect loader fields (#849)

* loader_fields fix

* tested, fixed

* added direct file check for invalid file_parts

* search fixes

* removed printlns

* Adds check for loaders

* removes println

tests/loader_fields.rs

@@ -1,11 +1,15 @@
 use std::collections::HashSet;
 
 use actix_http::StatusCode;
+use actix_web::test;
 use common::api_v3::ApiV3;
 use common::environment::{with_test_environment, TestEnvironment};
+use itertools::Itertools;
+use labrinth::models::v3;
 use serde_json::json;
 
-use crate::common::api_common::ApiVersion;
+use crate::common::api_common::{ApiProject, ApiVersion};
+use crate::common::api_v3::request_data::get_public_project_creation_data;
 use crate::common::database::*;
 
 use crate::common::dummy_data::{DummyProjectAlpha, DummyProjectBeta, TestFile};
@@ -461,3 +465,94 @@ async fn get_available_loader_fields() {
     })
     .await;
 }
+
+#[actix_rt::test]
+async fn test_multi_get_redis_cache() {
+    // Ensures a multi-project get including both modpacks and mods ddoes not
+    // incorrectly cache loader fields
+    with_test_environment(None, |test_env: TestEnvironment<ApiV3>| async move {
+        let api = &test_env.api;
+
+        // Create 5 modpacks
+        let mut modpacks = Vec::new();
+        for i in 0..5 {
+            let slug = format!("test-modpack-{}", i);
+
+            let creation_data = get_public_project_creation_data(
+                &slug,
+                Some(TestFile::build_random_mrpack()),
+                None,
+            );
+            let resp = api.create_project(creation_data, USER_USER_PAT).await;
+            assert_status!(&resp, StatusCode::OK);
+            modpacks.push(slug);
+        }
+
+        // Create 5 mods
+        let mut mods = Vec::new();
+        for i in 0..5 {
+            let slug = format!("test-mod-{}", i);
+
+            let creation_data =
+                get_public_project_creation_data(&slug, Some(TestFile::build_random_jar()), None);
+            let resp = api.create_project(creation_data, USER_USER_PAT).await;
+            assert_status!(&resp, StatusCode::OK);
+            mods.push(slug);
+        }
+
+        // Get all 10 projects
+        let project_slugs = modpacks
+            .iter()
+            .map(|x| x.as_str())
+            .chain(mods.iter().map(|x| x.as_str()))
+            .collect_vec();
+        let resp = api.get_projects(&project_slugs, USER_USER_PAT).await;
+        assert_status!(&resp, StatusCode::OK);
+        let projects: Vec<v3::projects::Project> = test::read_body_json(resp).await;
+        assert_eq!(projects.len(), 10);
+
+        // Ensure all 5 modpacks have 'mrpack_loaders', and all 5 mods do not
+        for project in projects.iter() {
+            if modpacks.contains(project.slug.as_ref().unwrap()) {
+                assert!(project.fields.contains_key("mrpack_loaders"));
+            } else if mods.contains(project.slug.as_ref().unwrap()) {
+                assert!(!project.fields.contains_key("mrpack_loaders"));
+            } else {
+                panic!("Unexpected project slug: {:?}", project.slug);
+            }
+        }
+
+        // Get a version from each project
+        let version_ids_modpacks = projects
+            .iter()
+            .filter(|x| modpacks.contains(x.slug.as_ref().unwrap()))
+            .map(|x| x.versions[0])
+            .collect_vec();
+        let version_ids_mods = projects
+            .iter()
+            .filter(|x| mods.contains(x.slug.as_ref().unwrap()))
+            .map(|x| x.versions[0])
+            .collect_vec();
+        let version_ids = version_ids_modpacks
+            .iter()
+            .chain(version_ids_mods.iter())
+            .map(|x| x.to_string())
+            .collect_vec();
+        let resp = api.get_versions(version_ids, USER_USER_PAT).await;
+        assert_status!(&resp, StatusCode::OK);
+        let versions: Vec<v3::projects::Version> = test::read_body_json(resp).await;
+        assert_eq!(versions.len(), 10);
+
+        // Ensure all 5 versions from modpacks have 'mrpack_loaders', and all 5 versions from mods do not
+        for version in versions.iter() {
+            if version_ids_modpacks.contains(&version.id) {
+                assert!(version.fields.contains_key("mrpack_loaders"));
+            } else if version_ids_mods.contains(&version.id) {
+                assert!(!version.fields.contains_key("mrpack_loaders"));
+            } else {
+                panic!("Unexpected version id: {:?}", version.id);
+            }
+        }
+    })
+    .await;
+}