Remove default description and license and add checklist nag for license (#892)

* Remove default description, remove default license, and add a checklist nag for setting a license

* Make Unknown license display nicer in License settings

Co-authored-by: Geometrically <18202329+Geometrically@users.noreply.github.com>
This commit is contained in:
Prospector
2023-01-11 10:06:29 -08:00
committed by GitHub
parent 61a4f15e53
commit aabf270144
3 changed files with 25 additions and 24 deletions

View File

@@ -157,27 +157,7 @@ export default {
project_type: projectType.actual, project_type: projectType.actual,
slug: this.slug, slug: this.slug,
description: this.description.trim(), description: this.description.trim(),
body: `# Placeholder description body: '',
This is your new ${projectType.display}, ${
this.name
}. A checklist below is provided to help prepare for release.
### Before submitting for review
- Upload at least one version
- [Edit project description](https://modrinth.com/${this.getProjectType().id}/${
this.slug
}/edit)
- Update metadata
- Select license
- Set up environments
- Choose categories
- Add source, wiki, Discord and donation links (optional)
- Add images to gallery (optional)
- Invite project team members (optional)
> Submissions are normally reviewed within 24 hours, but may take up to 48 hours
Questions? [Join the Modrinth Discord for support!](https://discord.gg/EUHuJHt)`,
initial_versions: [], initial_versions: [],
team_members: [ team_members: [
{ {
@@ -189,7 +169,7 @@ Questions? [Join the Modrinth Discord for support!](https://discord.gg/EUHuJHt)`
categories: [], categories: [],
client_side: this.getClientSide(), client_side: this.getClientSide(),
server_side: this.getServerSide(), server_side: this.getServerSide(),
license_id: 'LicenseRef-All-Rights-Reserved', license_id: 'LicenseRef-Unknown',
is_draft: true, is_draft: true,
}) })
) )

View File

@@ -256,6 +256,20 @@ export default {
hide: this.routeName === 'type-id-settings', hide: this.routeName === 'type-id-settings',
}, },
}, },
{
condition: this.project.license.id === 'LicenseRef-Unknown',
title: 'Select license',
id: 'select-license',
description: `Select the license your ${this.$formatProjectType(
this.project.project_type
).toLowerCase()} is distributed under.`,
status: 'required',
link: {
path: 'settings/license',
title: 'Visit license settings',
hide: this.routeName === 'type-id-settings-license',
},
},
{ {
condition: this.project.status === 'draft', condition: this.project.status === 'draft',
title: 'Submit for review', title: 'Submit for review',

View File

@@ -88,7 +88,7 @@
type="url" type="url"
maxlength="2048" maxlength="2048"
placeholder="License URL (optional)" placeholder="License URL (optional)"
:disabled="!hasPermission" :disabled="!hasPermission || licenseId === 'LicenseRef-Unknown'"
/> />
</div> </div>
</div> </div>
@@ -168,6 +168,12 @@ export default {
friendly: 'Custom', friendly: 'Custom',
short: licenseId.replaceAll('LicenseRef-', ''), short: licenseId.replaceAll('LicenseRef-', ''),
} }
if (licenseId === 'LicenseRef-Unknown') {
this.license = {
friendly: 'Unknown',
short: licenseId.replaceAll('LicenseRef-', ''),
}
}
this.allowOrLater = licenseId.includes('-or-later') this.allowOrLater = licenseId.includes('-or-later')
this.nonSpdxLicense = licenseId.includes('LicenseRef-') this.nonSpdxLicense = licenseId.includes('LicenseRef-')
}, },
@@ -180,7 +186,8 @@ export default {
let id = '' let id = ''
if ( if (
(this.nonSpdxLicense && this.license.friendly === 'Custom') || (this.nonSpdxLicense && this.license.friendly === 'Custom') ||
this.license.short === 'All-Rights-Reserved' this.license.short === 'All-Rights-Reserved' ||
this.license.short === 'Unknown'
) )
id += 'LicenseRef-' id += 'LicenseRef-'
id += this.license.short id += this.license.short