Performance improvements (#114)

* Performance improvements

* run fmt

* optimize creation modal

* remove print, fix mod loader editing

* Fix library update

* update extract loading bar

* Update theseus_gui/src-tauri/src/api/metadata.rs

Co-authored-by: triphora <emma@modrinth.com>

* fix cli

---------

Co-authored-by: triphora <emma@modrinth.com>

theseus_gui/src/pages/Browse.vue

@@ -167,15 +167,17 @@ watch(
         v-if="
           showLoaders &&
           searchStore.projectType !== 'datapack' &&
-          searchStore.projectType !== 'resourcepack' &&
-          searchStore.projectType !== 'shader'
+          searchStore.projectType !== 'resourcepack'
         "
         class="loaders"
       >
         <h2>Loaders</h2>
         <div
-          v-for="loader in loaders.filter((l) =>
-            l.supported_project_types?.includes(searchStore.projectType)
+          v-for="loader in loaders.filter(
+            (l) =>
+              (searchStore.projectType !== 'mod' &&
+                l.supported_project_types?.includes(searchStore.projectType)) ||
+              (searchStore.projectType === 'mod' && ['fabric', 'forge', 'quilt'].includes(l.name))
           )"
           :key="loader"
         >

theseus_gui/src/pages/Index.vue

@@ -16,11 +16,11 @@ const breadcrumbs = useBreadcrumbs()
 
 breadcrumbs.setRootContext({ name: 'Home', link: route.path })
 
-const recentInstances = shallowRef(Object.values(await list()))
+const recentInstances = shallowRef([])
 
 const getInstances = async () => {
   filter.value = ''
-  const profiles = await list()
+  const profiles = await list(true)
   recentInstances.value = Object.values(profiles)
 
   const excludeIds = recentInstances.value.map((i) => i.metadata?.linked_data?.project_id)
@@ -47,8 +47,8 @@ await getInstances()
 await Promise.all([getFeaturedModpacks(), getFeaturedMods()])
 
 const unlisten = await profile_listener(async (e) => {
+  await getInstances()
   if (e.event === 'created' || e.event === 'removed') {
-    await getInstances()
     await Promise.all([getFeaturedModpacks(), getFeaturedMods()])
   }
 })

theseus_gui/src/pages/Library.vue

@@ -4,21 +4,19 @@ import GridDisplay from '@/components/GridDisplay.vue'
 import { list } from '@/helpers/profile.js'
 import { useRoute } from 'vue-router'
 import { useBreadcrumbs } from '@/store/breadcrumbs'
-import { loading_listener } from '@/helpers/events.js'
+import { profile_listener } from '@/helpers/events.js'
 
 const route = useRoute()
 const breadcrumbs = useBreadcrumbs()
 
 breadcrumbs.setRootContext({ name: 'Library', link: route.path })
 
-const profiles = await list()
+const profiles = await list(true)
 const instances = shallowRef(Object.values(profiles))
 
-loading_listener(async (profile) => {
-  if (profile.event === 'loaded') {
-    const profiles = await list()
-    instances.value = Object.values(profiles)
-  }
+profile_listener(async () => {
+  const profiles = await list(true)
+  instances.value = Object.values(profiles)
 })
 </script>
 

theseus_gui/src/pages/instance/Index.vue

@@ -5,7 +5,8 @@
         <Avatar
           size="lg"
           :src="
-            instance.metadata.icon && instance.metadata.icon.startsWith('http')
+            !instance.metadata.icon ||
+            (instance.metadata.icon && instance.metadata.icon.startsWith('http'))
               ? instance.metadata.icon
               : convertFileSrc(instance.metadata?.icon)
           "

theseus_gui/src/pages/project/Index.vue

@@ -221,13 +221,13 @@ import {
 } from '@/assets/external'
 import { get_categories, get_loaders } from '@/helpers/tags'
 import { install as packInstall } from '@/helpers/pack'
-import { list, add_project_from_version as installMod } from '@/helpers/profile'
+import { list, add_project_from_version as installMod, check_installed } from '@/helpers/profile'
 import dayjs from 'dayjs'
 import relativeTime from 'dayjs/plugin/relativeTime'
 import { ofetch } from 'ofetch'
 import { useRoute, useRouter } from 'vue-router'
 import { ref, shallowRef, watch } from 'vue'
-import { checkInstalled, installVersionDependencies } from '@/helpers/utils'
+import { installVersionDependencies } from '@/helpers/utils'
 import InstallConfirmModal from '@/components/ui/InstallConfirmModal.vue'
 import InstanceInstallModal from '@/components/ui/InstanceInstallModal.vue'
 import Instance from '@/components/ui/Instance.vue'
@@ -242,19 +242,19 @@ const breadcrumbs = useBreadcrumbs()
 
 const confirmModal = ref(null)
 const modInstallModal = ref(null)
-const loaders = ref(await get_loaders())
-const categories = ref(await get_categories())
 const instance = ref(searchStore.instanceContext)
 const installing = ref(false)
 
-const [data, versions, members, dependencies] = await Promise.all([
+const [data, versions, members, dependencies, categories, loaders] = await Promise.all([
   ofetch(`https://api.modrinth.com/v2/project/${route.params.id}`).then(shallowRef),
   ofetch(`https://api.modrinth.com/v2/project/${route.params.id}/version`).then(shallowRef),
   ofetch(`https://api.modrinth.com/v2/project/${route.params.id}/members`).then(shallowRef),
   ofetch(`https://api.modrinth.com/v2/project/${route.params.id}/dependencies`).then(shallowRef),
+  get_loaders().then(ref),
+  get_categories().then(ref),
 ])
 
-const installed = ref(instance.value && checkInstalled(instance.value, data.value.id))
+const installed = ref(instance.value && (await check_installed(instance.value.path, data.value.id)))
 
 breadcrumbs.setName('Project', data.value.title)
 
@@ -284,7 +284,7 @@ async function install(version) {
   }
 
   if (data.value.project_type === 'modpack') {
-    const packs = Object.values(await list())
+    const packs = Object.values(await list(true))
     if (
       packs.length === 0 ||
       !packs
@@ -317,7 +317,7 @@ async function install(version) {
         await installMod(instance.value.path, queuedVersionData.id)
       }
 
-      installVersionDependencies(instance.value, queuedVersionData)
+      await installVersionDependencies(instance.value, queuedVersionData)
 
       installed.value = true
     } else {