Cleans up and removes TODOs, adds tests (#844)

* removes version ordering from v2; simplifies now-unecessary three-level faceting

* resolved some todos

* test for game version updating

* merge fixes; display_categories fix

tests/common/api_v3/tags.rs

@@ -85,7 +85,6 @@ impl ApiV3 {
         test::read_body_json(resp).await
     }
 
-    // TODO: fold this into v3 API of other v3 testing PR
     async fn get_games(&self) -> ServiceResponse {
         let req = TestRequest::get()
             .uri("/v3/games")

tests/common/api_v3/version.rs

@@ -66,6 +66,16 @@ impl ApiV3 {
         test::read_body_json(resp).await
     }
 
+    pub async fn get_versions_deserialized(
+        &self,
+        version_ids: Vec<String>,
+        pat: Option<&str>,
+    ) -> Vec<Version> {
+        let resp = self.get_versions(version_ids, pat).await;
+        assert_status!(&resp, StatusCode::OK);
+        test::read_body_json(resp).await
+    }
+
     pub async fn update_individual_files(
         &self,
         algorithm: &str,
@@ -454,7 +464,6 @@ impl ApiVersion for ApiV3 {
         serde_json::from_value(value).unwrap()
     }
 
-    // TODO: remove redundancy in these functions
     async fn edit_version_ordering(
         &self,
         version_id: &str,