chore(clippy): enable and fix many stricter lints (#3783)

* chore(clippy): enable and fix many stricter lints

These ensure that the codebase uses more idiomatic, performant, and
concise language constructions.

* chore: make non-Clippy compiler warnings also deny by default
This commit is contained in:
Alejandro González
2025-06-14 02:10:12 +02:00
committed by GitHub
parent 301967d204
commit f84f8c1c2b
106 changed files with 542 additions and 760 deletions

View File

@@ -22,7 +22,7 @@ use common::{
use labrinth::models::teams::{OrganizationPermissions, ProjectPermissions};
use serde_json::json;
mod common;
pub mod common;
#[actix_rt::test]
async fn create_organization() {
@@ -583,9 +583,7 @@ async fn add_remove_organization_project_ownership_to_user() {
.await;
assert_eq!(members.len(), 1);
assert_eq!(members[0].user.id.to_string(), FRIEND_USER_ID);
let user_member =
members.iter().filter(|m| m.is_owner).collect::<Vec<_>>();
assert_eq!(user_member.len(), 0);
assert_eq!(members.iter().filter(|m| m.is_owner).count(), 0);
// Beta project should have:
// - No members
@@ -836,9 +834,7 @@ async fn delete_organization_means_all_projects_to_org_owner() {
.api
.get_team_members_deserialized(alpha_team_id, USER_USER_PAT)
.await;
let user_member =
members.iter().filter(|m| m.is_owner).collect::<Vec<_>>();
assert_eq!(user_member.len(), 0);
assert_eq!(members.iter().filter(|m| m.is_owner).count(), 0);
// Transfer ownership of zeta organization to FRIEND
let resp = test_env
@@ -856,9 +852,7 @@ async fn delete_organization_means_all_projects_to_org_owner() {
.api
.get_team_members_deserialized(alpha_team_id, USER_USER_PAT)
.await;
let user_member =
members.iter().filter(|m| m.is_owner).collect::<Vec<_>>();
assert_eq!(user_member.len(), 0);
assert_eq!(members.iter().filter(|m| m.is_owner).count(), 0);
// Delete organization
let resp = test_env