Bugs again (#703)

* initial

* more fixes

* logs

* more fixes

* working rescuer

* minor log display fix

* mac fixes

* minor fix

* libsselinux1

* linux error

* actions test

* more bugs. Modpack page! BIG changes

* changed minimum 64 -> 8

* removed modpack page moved to modal

* removed unnecessary css

* mac compile

* many revs

* Merge colorful logs (#725)

* make implementation not dumb

* run prettier

* null -> true

* Add line numbers & make errors more robust.

* improvments

* changes; virtual scroll

---------

Co-authored-by: qtchaos <72168435+qtchaos@users.noreply.github.com>

* omorphia colors, comments fix

* fixes; _JAVA_OPTIONS

* revs

* mac specific

* more mac

* some fixes

* quick fix

* add java reinstall option

---------

Co-authored-by: qtchaos <72168435+qtchaos@users.noreply.github.com>
Co-authored-by: Jai A <jaiagr+gpg@pm.me>

theseus/src/api/auth.rs

@@ -1,5 +1,9 @@
 //! Authentication flow interface
-use crate::{hydra::init::DeviceLoginSuccess, launcher::auth as inner, State};
+use crate::{
+    hydra::{self, init::DeviceLoginSuccess},
+    launcher::auth as inner,
+    State,
+};
 use chrono::Utc;
 
 use crate::state::AuthTask;
@@ -44,20 +48,34 @@ pub async fn refresh(user: uuid::Uuid) -> crate::Result<Credentials> {
         .as_error()
     })?;
 
-    let fetch_semaphore = &state.fetch_semaphore;
-    if Utc::now() > credentials.expires
-        && inner::refresh_credentials(&mut credentials, fetch_semaphore)
-            .await
-            .is_err()
-    {
-        users.remove(credentials.id).await?;
+    let offline = *state.offline.read().await;
 
-        return Err(crate::ErrorKind::OtherError(
-            "Please re-authenticate with your Minecraft account!".to_string(),
-        )
-        .as_error());
+    if !offline {
+        let fetch_semaphore: &crate::util::fetch::FetchSemaphore =
+            &state.fetch_semaphore;
+        if Utc::now() > credentials.expires
+            && inner::refresh_credentials(&mut credentials, fetch_semaphore)
+                .await
+                .is_err()
+        {
+            users.remove(credentials.id).await?;
+
+            return Err(crate::ErrorKind::OtherError(
+                "Please re-authenticate with your Minecraft account!"
+                    .to_string(),
+            )
+            .as_error());
+        }
+
+        // Update player info from bearer token
+        let player_info = hydra::stages::player_info::fetch_info(&credentials.access_token).await.map_err(|_err| {
+            crate::ErrorKind::HydraError("No Minecraft account for your profile. Make sure you own the game and have set a username through the official Minecraft launcher."
+        .to_string())
+        })?;
+
+        credentials.username = player_info.name;
+        users.insert(&credentials).await?;
     }
-    users.insert(&credentials).await?;
 
     Ok(credentials)
 }

theseus/src/api/jre.rs

@@ -7,6 +7,7 @@ use crate::event::emit::{emit_loading, init_loading};
 use crate::state::CredentialsStore;
 use crate::util::fetch::{fetch_advanced, fetch_json};
 
+use crate::util::io;
 use crate::util::jre::extract_java_majorminor_version;
 use crate::{
     state::JavaGlobals,
@@ -92,7 +93,7 @@ pub async fn auto_install_java(java_version: u32) -> crate::Result<PathBuf> {
     let packages = fetch_json::<Vec<Package>>(
                 Method::GET,
                 &format!(
-                    "https://api.azul.com/metadata/v1/zulu/packages?arch={}&java_version={}&os={}&archive_type=zip&javafx_bundled=false&java_package_type=jdk&page_size=1",
+                    "https://api.azul.com/metadata/v1/zulu/packages?arch={}&java_version={}&os={}&archive_type=zip&javafx_bundled=false&java_package_type=jre&page_size=1",
                     std::env::consts::ARCH, java_version, std::env::consts::OS
                 ),
                 None,
@@ -124,6 +125,17 @@ pub async fn auto_install_java(java_version: u32) -> crate::Result<PathBuf> {
                 ))
             })?;
 
+        // removes the old installation of java
+        if let Some(file) = archive.file_names().next() {
+            if let Some(dir) = file.split("/").next() {
+                let path = path.join(dir);
+
+                if path.exists() {
+                    io::remove_dir_all(path).await?;
+                }
+            }
+        }
+
         emit_loading(&loading_bar, 0.0, Some("Extracting java")).await?;
         archive.extract(&path).map_err(|_| {
             crate::Error::from(crate::ErrorKind::InputError(
@@ -180,6 +192,20 @@ pub async fn check_jre(path: PathBuf) -> crate::Result<Option<JavaVersion>> {
     Ok(jre::check_java_at_filepath(&path).await)
 }
 
+// Test JRE at a given path
+pub async fn test_jre(
+    path: PathBuf,
+    major_version: u32,
+    minor_version: u32,
+) -> crate::Result<bool> {
+    let jre = match jre::check_java_at_filepath(&path).await {
+        Some(jre) => jre,
+        None => return Ok(false),
+    };
+    let (major, minor) = extract_java_majorminor_version(&jre.version)?;
+    Ok(major == major_version && minor == minor_version)
+}
+
 // Gets maximum memory in KiB.
 pub async fn get_max_memory() -> crate::Result<u64> {
     Ok(sys_info::mem_info()

theseus/src/api/logs.rs

@@ -1,30 +1,70 @@
+use std::io::{Read, SeekFrom};
+
 use crate::{
+    prelude::Credentials,
     util::io::{self, IOError},
     {state::ProfilePathId, State},
 };
-use serde::{Deserialize, Serialize};
+use futures::TryFutureExt;
+use serde::Serialize;
+use tokio::{
+    fs::File,
+    io::{AsyncReadExt, AsyncSeekExt},
+};
 
-#[derive(Serialize, Deserialize, Debug)]
+#[derive(Serialize, Debug)]
 pub struct Logs {
-    pub datetime_string: String,
-    pub output: Option<String>,
+    pub filename: String,
+    pub output: Option<CensoredString>,
 }
+
+#[derive(Serialize, Debug)]
+pub struct LatestLogCursor {
+    pub cursor: u64,
+    pub output: CensoredString,
+    pub new_file: bool,
+}
+
+#[derive(Serialize, Debug)] // Not deserialize
+#[serde(transparent)]
+pub struct CensoredString(String);
+impl CensoredString {
+    pub fn censor(mut s: String, credentials_set: &Vec<Credentials>) -> Self {
+        let username = whoami::username();
+        s = s
+            .replace(&format!("/{}/", username), "/{COMPUTER_USERNAME}/")
+            .replace(&format!("\\{}\\", username), "\\{COMPUTER_USERNAME}\\");
+        for credentials in credentials_set {
+            s = s
+                .replace(&credentials.access_token, "{MINECRAFT_ACCESS_TOKEN}")
+                .replace(&credentials.username, "{MINECRAFT_USERNAME}")
+                .replace(
+                    &credentials.id.as_simple().to_string(),
+                    "{MINECRAFT_UUID}",
+                )
+                .replace(
+                    &credentials.id.as_hyphenated().to_string(),
+                    "{MINECRAFT_UUID}",
+                );
+        }
+
+        Self(s)
+    }
+}
+
 impl Logs {
     async fn build(
         profile_subpath: &ProfilePathId,
-        datetime_string: String,
+        filename: String,
         clear_contents: Option<bool>,
     ) -> crate::Result<Self> {
         Ok(Self {
             output: if clear_contents.unwrap_or(false) {
                 None
             } else {
-                Some(
-                    get_output_by_datetime(profile_subpath, &datetime_string)
-                        .await?,
-                )
+                Some(get_output_by_filename(profile_subpath, &filename).await?)
             },
-            datetime_string,
+            filename,
         })
     }
 }
@@ -51,33 +91,31 @@ pub async fn get_logs(
         for entry in std::fs::read_dir(&logs_folder)
             .map_err(|e| IOError::with_path(e, &logs_folder))?
         {
-            let entry =
+            let entry: std::fs::DirEntry =
                 entry.map_err(|e| IOError::with_path(e, &logs_folder))?;
             let path = entry.path();
-            if path.is_dir() {
-                if let Some(datetime_string) = path.file_name() {
-                    logs.push(
-                        Logs::build(
-                            &profile_path,
-                            datetime_string.to_string_lossy().to_string(),
-                            clear_contents,
-                        )
-                        .await,
-                    );
-                }
+            if !path.is_file() {
+                continue;
+            }
+            if let Some(file_name) = path.file_name() {
+                let file_name = file_name.to_string_lossy().to_string();
+
+                logs.push(
+                    Logs::build(&profile_path, file_name, clear_contents).await,
+                );
             }
         }
     }
 
     let mut logs = logs.into_iter().collect::<crate::Result<Vec<Logs>>>()?;
-    logs.sort_by_key(|x| x.datetime_string.clone());
+    logs.sort_by_key(|x| x.filename.clone());
     Ok(logs)
 }
 
 #[tracing::instrument]
-pub async fn get_logs_by_datetime(
+pub async fn get_logs_by_filename(
     profile_path: ProfilePathId,
-    datetime_string: String,
+    filename: String,
 ) -> crate::Result<Logs> {
     let profile_path =
         if let Some(p) = crate::profile::get(&profile_path, None).await? {
@@ -89,23 +127,66 @@ pub async fn get_logs_by_datetime(
             .into());
         };
     Ok(Logs {
-        output: Some(
-            get_output_by_datetime(&profile_path, &datetime_string).await?,
-        ),
-        datetime_string,
+        output: Some(get_output_by_filename(&profile_path, &filename).await?),
+        filename,
     })
 }
 
 #[tracing::instrument]
-pub async fn get_output_by_datetime(
+pub async fn get_output_by_filename(
     profile_subpath: &ProfilePathId,
-    datetime_string: &str,
-) -> crate::Result<String> {
+    file_name: &str,
+) -> crate::Result<CensoredString> {
     let state = State::get().await?;
     let logs_folder =
         state.directories.profile_logs_dir(profile_subpath).await?;
-    let path = logs_folder.join(datetime_string).join("stdout.log");
-    Ok(io::read_to_string(&path).await?)
+    let path = logs_folder.join(file_name);
+
+    let credentials: Vec<Credentials> =
+        state.users.read().await.clone().0.into_values().collect();
+
+    // Load .gz file into String
+    if let Some(ext) = path.extension() {
+        if ext == "gz" {
+            let file = std::fs::File::open(&path)
+                .map_err(|e| IOError::with_path(e, &path))?;
+            let mut contents = [0; 1024];
+            let mut result = String::new();
+            let mut gz =
+                flate2::read::GzDecoder::new(std::io::BufReader::new(file));
+
+            while gz
+                .read(&mut contents)
+                .map_err(|e| IOError::with_path(e, &path))?
+                > 0
+            {
+                result.push_str(&String::from_utf8_lossy(&contents));
+                contents = [0; 1024];
+            }
+            return Ok(CensoredString::censor(result, &credentials));
+        } else if ext == "log" {
+            let mut result = String::new();
+            let mut contents = [0; 1024];
+            let mut file = std::fs::File::open(&path)
+                .map_err(|e| IOError::with_path(e, &path))?;
+            // iteratively read the file to a String
+            while file
+                .read(&mut contents)
+                .map_err(|e| IOError::with_path(e, &path))?
+                > 0
+            {
+                result.push_str(&String::from_utf8_lossy(&contents));
+                contents = [0; 1024];
+            }
+            let result = CensoredString::censor(result, &credentials);
+            return Ok(result);
+        }
+    }
+    Err(crate::ErrorKind::OtherError(format!(
+        "File extension not supported: {}",
+        path.display()
+    ))
+    .into())
 }
 
 #[tracing::instrument]
@@ -135,9 +216,9 @@ pub async fn delete_logs(profile_path: ProfilePathId) -> crate::Result<()> {
 }
 
 #[tracing::instrument]
-pub async fn delete_logs_by_datetime(
+pub async fn delete_logs_by_filename(
     profile_path: ProfilePathId,
-    datetime_string: &str,
+    filename: &str,
 ) -> crate::Result<()> {
     let profile_path =
         if let Some(p) = crate::profile::get(&profile_path, None).await? {
@@ -151,7 +232,71 @@ pub async fn delete_logs_by_datetime(
 
     let state = State::get().await?;
     let logs_folder = state.directories.profile_logs_dir(&profile_path).await?;
-    let path = logs_folder.join(datetime_string);
+    let path = logs_folder.join(filename);
     io::remove_dir_all(&path).await?;
     Ok(())
 }
+
+#[tracing::instrument]
+pub async fn get_latest_log_cursor(
+    profile_path: ProfilePathId,
+    mut cursor: u64, // 0 to start at beginning of file
+) -> crate::Result<LatestLogCursor> {
+    let profile_path =
+        if let Some(p) = crate::profile::get(&profile_path, None).await? {
+            p.profile_id()
+        } else {
+            return Err(crate::ErrorKind::UnmanagedProfileError(
+                profile_path.to_string(),
+            )
+            .into());
+        };
+
+    let state = State::get().await?;
+    let logs_folder = state.directories.profile_logs_dir(&profile_path).await?;
+    let path = logs_folder.join("latest.log");
+    if !path.exists() {
+        // Allow silent failure if latest.log doesn't exist (as the instance may have been launched, but not yet created the file)
+        return Ok(LatestLogCursor {
+            cursor: 0,
+            new_file: false,
+            output: CensoredString("".to_string()),
+        });
+    }
+
+    let mut file = File::open(&path)
+        .await
+        .map_err(|e| IOError::with_path(e, &path))?;
+    let metadata = file
+        .metadata()
+        .await
+        .map_err(|e| IOError::with_path(e, &path))?;
+
+    let mut new_file = false;
+    if cursor > metadata.len() {
+        // Cursor is greater than file length, reset cursor to 0
+        // Likely cause is that the file was rotated while the log was being read
+        cursor = 0;
+        new_file = true;
+    }
+
+    let mut buffer = Vec::new();
+    file.seek(SeekFrom::Start(cursor))
+        .map_err(|e| IOError::with_path(e, &path))
+        .await?; // Seek to cursor
+    let bytes_read = file
+        .read_to_end(&mut buffer)
+        .map_err(|e| IOError::with_path(e, &path))
+        .await?; // Read to end of file
+    let output = String::from_utf8_lossy(&buffer).to_string(); // Convert to String
+    let cursor = cursor + bytes_read as u64; // Update cursor
+
+    let credentials: Vec<Credentials> =
+        state.users.read().await.clone().0.into_values().collect();
+    let output = CensoredString::censor(output, &credentials);
+    Ok(LatestLogCursor {
+        cursor,
+        new_file,
+        output,
+    })
+}

theseus/src/api/pack/import/atlauncher.rs

@@ -218,6 +218,10 @@ async fn import_atlauncher_unmanaged(
         prof.metadata.linked_data = Some(LinkedData {
             project_id: description.project_id.clone(),
             version_id: description.version_id.clone(),
+            locked: Some(
+                description.project_id.is_some()
+                    && description.version_id.is_some(),
+            ),
         });
         prof.metadata.icon = description.icon.clone();
         prof.metadata.game_version = game_version.clone();

theseus/src/api/pack/import/mmc.rs

@@ -306,6 +306,7 @@ async fn import_mmc_unmanaged(
         &description,
         &backup_name,
         &dependencies,
+        false,
     )
     .await?;
 

theseus/src/api/pack/import/mod.rs

@@ -251,7 +251,7 @@ pub async fn recache_icon(
     }
 }
 
-async fn copy_dotminecraft(
+pub async fn copy_dotminecraft(
     profile_path_id: ProfilePathId,
     dotminecraft: PathBuf,
     io_semaphore: &IoSemaphore,

theseus/src/api/pack/install_from.rs

@@ -153,6 +153,7 @@ pub fn get_profile_from_pack(
             linked_data: Some(LinkedData {
                 project_id: Some(project_id),
                 version_id: Some(version_id),
+                locked: Some(true),
             }),
             ..Default::default()
         },
@@ -179,20 +180,29 @@ pub async fn generate_pack_from_version_id(
     title: String,
     icon_url: Option<String>,
     profile_path: ProfilePathId,
+
+    // Existing loading bar. Unlike when existing_loading_bar is used, this one is pre-initialized with PackFileDownload
+    // For example, you might use this if multiple packs are being downloaded at once and you want to use the same loading bar
+    initialized_loading_bar: Option<LoadingBarId>,
 ) -> crate::Result<CreatePack> {
     let state = State::get().await?;
 
-    let loading_bar = init_loading(
-        LoadingBarType::PackFileDownload {
-            profile_path: profile_path.get_full_path().await?,
-            pack_name: title,
-            icon: icon_url,
-            pack_version: version_id.clone(),
-        },
-        100.0,
-        "Downloading pack file",
-    )
-    .await?;
+    let loading_bar = if let Some(bar) = initialized_loading_bar {
+        emit_loading(&bar, 0.0, Some("Downloading pack file")).await?;
+        bar
+    } else {
+        init_loading(
+            LoadingBarType::PackFileDownload {
+                profile_path: profile_path.get_full_path().await?,
+                pack_name: title,
+                icon: icon_url,
+                pack_version: version_id.clone(),
+            },
+            100.0,
+            "Downloading pack file",
+        )
+        .await?
+    };
 
     emit_loading(&loading_bar, 0.0, Some("Fetching version")).await?;
     let creds = state.credentials.read().await;
@@ -313,6 +323,7 @@ pub async fn set_profile_information(
     description: &CreatePackDescription,
     backup_name: &str,
     dependencies: &HashMap<PackDependency, String>,
+    ignore_lock: bool, // do not change locked status
 ) -> crate::Result<()> {
     let mut game_version: Option<&String> = None;
     let mut mod_loader = None;
@@ -370,6 +381,14 @@ pub async fn set_profile_information(
         prof.metadata.linked_data = Some(LinkedData {
             project_id: description.project_id.clone(),
             version_id: description.version_id.clone(),
+            locked: if !ignore_lock {
+                Some(
+                    description.project_id.is_some()
+                        && description.version_id.is_some(),
+                )
+            } else {
+                prof.metadata.linked_data.as_ref().and_then(|x| x.locked)
+            },
         });
         prof.metadata.icon = description.icon.clone();
         prof.metadata.game_version = game_version.clone();

theseus/src/api/pack/install_mrpack.rs

@@ -1,3 +1,4 @@
+use crate::config::MODRINTH_API_URL;
 use crate::event::emit::{
     emit_loading, init_or_edit_loading, loading_try_for_each_concurrent,
 };
@@ -5,13 +6,16 @@ use crate::event::LoadingBarType;
 use crate::pack::install_from::{
     set_profile_information, EnvType, PackFile, PackFileHash,
 };
-use crate::prelude::ProfilePathId;
+use crate::prelude::{ModrinthVersion, ProfilePathId, ProjectMetadata};
 use crate::state::{ProfileInstallStage, Profiles, SideType};
-use crate::util::fetch::{fetch_mirrors, write};
+use crate::util::fetch::{fetch_json, fetch_mirrors, write};
 use crate::util::io;
 use crate::{profile, State};
 use async_zip::tokio::read::seek::ZipFileReader;
+use reqwest::Method;
+use serde_json::json;
 
+use std::collections::HashMap;
 use std::io::Cursor;
 use std::path::{Component, PathBuf};
 
@@ -43,6 +47,7 @@ pub async fn install_zipped_mrpack(
                 title,
                 icon_url,
                 profile_path.clone(),
+                None,
             )
             .await?
         }
@@ -52,7 +57,7 @@ pub async fn install_zipped_mrpack(
     };
 
     // Install pack files, and if it fails, fail safely by removing the profile
-    let result = install_zipped_mrpack_files(create_pack).await;
+    let result = install_zipped_mrpack_files(create_pack, false).await;
 
     // Check existing managed packs for potential updates
     tokio::task::spawn(Profiles::update_modrinth_versions());
@@ -72,6 +77,7 @@ pub async fn install_zipped_mrpack(
 #[theseus_macros::debug_pin]
 pub async fn install_zipped_mrpack_files(
     create_pack: CreatePack,
+    ignore_lock: bool,
 ) -> crate::Result<ProfilePathId> {
     let state = &State::get().await?;
 
@@ -126,6 +132,7 @@ pub async fn install_zipped_mrpack_files(
             &description,
             &pack.name,
             &pack.dependencies,
+            ignore_lock,
         )
         .await?;
 
@@ -182,15 +189,20 @@ pub async fn install_zipped_mrpack_files(
                     .await?;
                     drop(creds);
 
+                    // Convert windows path to unix path.
+                    // .mrpacks no longer generate windows paths, but this is here for backwards compatibility before this was fixed
+                    // https://github.com/modrinth/theseus/issues/595
+                    let project_path = project.path.replace('\\', "/");
+
                     let path =
-                        std::path::Path::new(&project.path).components().next();
+                        std::path::Path::new(&project_path).components().next();
                     if let Some(path) = path {
                         match path {
                             Component::CurDir | Component::Normal(_) => {
                                 let path = profile_path
                                     .get_full_path()
                                     .await?
-                                    .join(&project.path);
+                                    .join(&project_path);
                                 write(&path, &file, &state.io_semaphore)
                                     .await?;
                             }
@@ -337,31 +349,65 @@ pub async fn remove_all_related_files(
         })
         .await?;
 
-        let num_files = pack.files.len();
-        use futures::StreamExt;
-        loading_try_for_each_concurrent(
-            futures::stream::iter(pack.files.into_iter())
-                .map(Ok::<PackFile, crate::Error>),
-            None,
-            None,
-            0.0,
-            num_files,
-            None,
-            |project| {
-                let profile_path = profile_path.clone();
-                async move {
-                    // Remove this file if a corresponding one exists in the filesystem
-                    let existing_file =
-                        profile_path.get_full_path().await?.join(&project.path);
-                    if existing_file.exists() {
-                        io::remove_file(&existing_file).await?;
-                    }
+        // First, remove all modrinth projects by their version hashes
+        // Remove all modrinth projects by their version hashes
+        // We need to do a fetch to get the project ids from Modrinth
+        let state = State::get().await?;
+        let all_hashes = pack
+            .files
+            .iter()
+            .filter_map(|f| Some(f.hashes.get(&PackFileHash::Sha512)?.clone()))
+            .collect::<Vec<_>>();
+        let creds = state.credentials.read().await;
 
-                    Ok(())
-                }
-            },
+        // First, get project info by hash
+        let files_url = format!("{}version_files", MODRINTH_API_URL);
+
+        let hash_projects = fetch_json::<HashMap<String, ModrinthVersion>>(
+            Method::POST,
+            &files_url,
+            None,
+            Some(json!({
+                "hashes": all_hashes,
+                "algorithm": "sha512",
+            })),
+            &state.fetch_semaphore,
+            &creds,
         )
         .await?;
+        let to_remove = hash_projects
+            .into_values()
+            .map(|p| p.project_id)
+            .collect::<Vec<_>>();
+        let profile =
+            profile::get(&profile_path, None).await?.ok_or_else(|| {
+                crate::ErrorKind::UnmanagedProfileError(
+                    profile_path.to_string(),
+                )
+            })?;
+        for (project_id, project) in &profile.projects {
+            if let ProjectMetadata::Modrinth { project, .. } = &project.metadata
+            {
+                if to_remove.contains(&project.id) {
+                    let path = profile
+                        .get_profile_full_path()
+                        .await?
+                        .join(project_id.0.clone());
+                    if path.exists() {
+                        io::remove_file(&path).await?;
+                    }
+                }
+            }
+        }
+
+        // Iterate over all Modrinth project file paths in the json, and remove them
+        // (There should be few, but this removes any files the .mrpack intended as Modrinth projects but were unrecognized)
+        for file in pack.files {
+            let path = profile_path.get_full_path().await?.join(file.path);
+            if path.exists() {
+                io::remove_file(&path).await?;
+            }
+        }
 
         // Iterate over each 'overrides' file and remove it
         for index in 0..zip_reader.file().entries().len() {

theseus/src/api/process.rs

@@ -2,16 +2,13 @@
 
 use uuid::Uuid;
 
+use crate::state::{MinecraftChild, ProfilePathId};
 pub use crate::{
     state::{
         Hooks, JavaSettings, MemorySettings, Profile, Settings, WindowSize,
     },
     State,
 };
-use crate::{
-    state::{MinecraftChild, ProfilePathId},
-    util::io::IOError,
-};
 
 // Gets whether a child process stored in the state by UUID has finished
 #[tracing::instrument]
@@ -26,7 +23,7 @@ pub async fn get_exit_status_by_uuid(
 ) -> crate::Result<Option<i32>> {
     let state = State::get().await?;
     let children = state.children.read().await;
-    Ok(children.exit_status(uuid).await?.and_then(|f| f.code()))
+    children.exit_status(uuid).await
 }
 
 // Gets the UUID of each stored process in the state
@@ -72,26 +69,6 @@ pub async fn get_uuids_by_profile_path(
     children.running_keys_with_profile(profile_path).await
 }
 
-// Gets output of a child process stored in the state by UUID, as a string
-#[tracing::instrument]
-pub async fn get_output_by_uuid(uuid: &Uuid) -> crate::Result<String> {
-    let state = State::get().await?;
-    // Get stdout from child
-    let children = state.children.read().await;
-
-    // Extract child or return crate::Error
-    if let Some(child) = children.get(uuid) {
-        let child = child.read().await;
-        Ok(child.output.get_output().await?)
-    } else {
-        Err(crate::ErrorKind::LauncherError(format!(
-            "No child process by UUID {}",
-            uuid
-        ))
-        .as_error())
-    }
-}
-
 // Kill a child process stored in the state by UUID, as a string
 #[tracing::instrument]
 pub async fn kill_by_uuid(uuid: &Uuid) -> crate::Result<()> {
@@ -124,13 +101,7 @@ pub async fn wait_for_by_uuid(uuid: &Uuid) -> crate::Result<()> {
 // Kill a running child process directly
 #[tracing::instrument(skip(running))]
 pub async fn kill(running: &mut MinecraftChild) -> crate::Result<()> {
-    running
-        .current_child
-        .write()
-        .await
-        .kill()
-        .await
-        .map_err(IOError::from)?;
+    running.current_child.write().await.kill().await?;
     Ok(())
 }
 

theseus/src/api/profile/create.rs

@@ -1,13 +1,13 @@
 //! Theseus profile management interface
 use crate::pack::install_from::CreatePackProfile;
 use crate::prelude::ProfilePathId;
-use crate::profile;
 use crate::state::LinkedData;
 use crate::util::io::{self, canonicalize};
 use crate::{
     event::{emit::emit_profile, ProfilePayloadType},
     prelude::ModLoader,
 };
+use crate::{pack, profile, ErrorKind};
 pub use crate::{
     state::{JavaSettings, Profile},
     State,
@@ -102,6 +102,12 @@ pub async fn profile_create(
         }
 
         profile.metadata.linked_data = linked_data;
+        if let Some(linked_data) = &mut profile.metadata.linked_data {
+            linked_data.locked = Some(
+                linked_data.project_id.is_some()
+                    && linked_data.version_id.is_some(),
+            );
+        }
 
         emit_profile(
             uuid,
@@ -154,6 +160,59 @@ pub async fn profile_create_from_creator(
     .await
 }
 
+pub async fn profile_create_from_duplicate(
+    copy_from: ProfilePathId,
+) -> crate::Result<ProfilePathId> {
+    let profile = profile::get(&copy_from, None).await?.ok_or_else(|| {
+        ErrorKind::UnmanagedProfileError(copy_from.to_string())
+    })?;
+
+    let profile_path_id = profile_create(
+        profile.metadata.name.clone(),
+        profile.metadata.game_version.clone(),
+        profile.metadata.loader,
+        profile.metadata.loader_version.clone().map(|it| it.id),
+        profile.metadata.icon.clone(),
+        profile.metadata.icon_url.clone(),
+        profile.metadata.linked_data.clone(),
+        Some(true),
+        Some(true),
+    )
+    .await?;
+
+    // Copy it over using the import system (essentially importing from the same profile)
+    let state = State::get().await?;
+    let bar = pack::import::copy_dotminecraft(
+        profile_path_id.clone(),
+        copy_from.get_full_path().await?,
+        &state.io_semaphore,
+        None,
+    )
+    .await?;
+
+    crate::launcher::install_minecraft(&profile, Some(bar)).await?;
+    {
+        let state = State::get().await?;
+        let mut file_watcher = state.file_watcher.write().await;
+        Profile::watch_fs(
+            &profile.get_profile_full_path().await?,
+            &mut file_watcher,
+        )
+        .await?;
+    }
+
+    // emit profile edited
+    emit_profile(
+        profile.uuid,
+        &profile.profile_id(),
+        &profile.metadata.name,
+        ProfilePayloadType::Edited,
+    )
+    .await?;
+    State::sync().await?;
+    Ok(profile_path_id)
+}
+
 #[tracing::instrument]
 #[theseus_macros::debug_pin]
 pub(crate) async fn get_loader_version_from_loader(

theseus/src/api/profile/mod.rs

@@ -8,7 +8,7 @@ use crate::pack::install_from::{
     EnvType, PackDependency, PackFile, PackFileHash, PackFormat,
 };
 use crate::prelude::{JavaVersion, ProfilePathId, ProjectPathId};
-use crate::state::ProjectMetadata;
+use crate::state::{ProjectMetadata, SideType};
 
 use crate::util::fetch;
 use crate::util::io::{self, IOError};
@@ -109,6 +109,26 @@ pub async fn get_full_path(path: &ProfilePathId) -> crate::Result<PathBuf> {
     Ok(full_path)
 }
 
+/// Get mod's full path in the filesystem
+#[tracing::instrument]
+pub async fn get_mod_full_path(
+    profile_path: &ProfilePathId,
+    project_path: &ProjectPathId,
+) -> crate::Result<PathBuf> {
+    if get(profile_path, Some(true)).await?.is_some() {
+        let full_path = io::canonicalize(
+            project_path.get_full_path(profile_path.clone()).await?,
+        )?;
+        return Ok(full_path);
+    }
+
+    Err(crate::ErrorKind::OtherError(format!(
+        "Tried to get the full path of a nonexistent or unloaded project at path {}!",
+        project_path.get_full_path(profile_path.clone()).await?.display()
+    ))
+    .into())
+}
+
 /// Edit a profile using a given asynchronous closure
 pub async fn edit<Fut>(
     path: &ProfilePathId,
@@ -552,6 +572,8 @@ pub async fn export_mrpack(
     export_path: PathBuf,
     included_overrides: Vec<String>, // which folders to include in the overrides
     version_id: Option<String>,
+    description: Option<String>,
+    _name: Option<String>,
 ) -> crate::Result<()> {
     let state = State::get().await?;
     let io_semaphore = state.io_semaphore.0.read().await;
@@ -585,7 +607,8 @@ pub async fn export_mrpack(
 
     // Create mrpack json configuration file
     let version_id = version_id.unwrap_or("1.0.0".to_string());
-    let packfile = create_mrpack_json(&profile, version_id).await?;
+    let packfile =
+        create_mrpack_json(&profile, version_id, description).await?;
     let modrinth_path_list = get_modrinth_pack_list(&packfile);
 
     // Build vec of all files in the folder
@@ -693,7 +716,7 @@ pub async fn get_potential_override_folders(
             ))
         })?;
     // dummy mrpack to get pack list
-    let mrpack = create_mrpack_json(&profile, "0".to_string()).await?;
+    let mrpack = create_mrpack_json(&profile, "0".to_string(), None).await?;
     let mrpack_files = get_modrinth_pack_list(&mrpack);
 
     let mut path_list: Vec<PathBuf> = Vec::new();
@@ -820,23 +843,12 @@ pub async fn run_credentials(
         .unwrap_or(&settings.custom_env_args);
 
     // Post post exit hooks
-    let post_exit_hook =
-        &profile.hooks.as_ref().unwrap_or(&settings.hooks).post_exit;
-
-    let post_exit_hook = if let Some(hook) = post_exit_hook {
-        let mut cmd = hook.split(' ');
-        if let Some(command) = cmd.next() {
-            let mut command = Command::new(command);
-            command
-                .args(&cmd.collect::<Vec<&str>>())
-                .current_dir(path.get_full_path().await?);
-            Some(command)
-        } else {
-            None
-        }
-    } else {
-        None
-    };
+    let post_exit_hook = profile
+        .hooks
+        .as_ref()
+        .unwrap_or(&settings.hooks)
+        .post_exit
+        .clone();
 
     // Any options.txt settings that we want set, add here
     let mut mc_set_options: Vec<(String, String)> = vec![];
@@ -941,6 +953,7 @@ fn get_modrinth_pack_list(packfile: &PackFormat) -> Vec<String> {
 pub async fn create_mrpack_json(
     profile: &Profile,
     version_id: String,
+    description: Option<String>,
 ) -> crate::Result<PackFormat> {
     // Add loader version to dependencies
     let mut dependencies = HashMap::new();
@@ -951,6 +964,9 @@ pub async fn create_mrpack_json(
         (crate::prelude::ModLoader::Forge, Some(v)) => {
             dependencies.insert(PackDependency::Forge, v.id)
         }
+        (crate::prelude::ModLoader::NeoForge, Some(v)) => {
+            dependencies.insert(PackDependency::NeoForge, v.id)
+        }
         (crate::prelude::ModLoader::Fabric, Some(v)) => {
             dependencies.insert(PackDependency::FabricLoader, v.id)
         }
@@ -981,18 +997,21 @@ pub async fn create_mrpack_json(
         .projects
         .iter()
         .filter_map(|(mod_path, project)| {
-            let path: String = mod_path.0.clone().to_string_lossy().to_string();
+            let path: String = mod_path.get_inner_path_unix().ok()?;
 
             // Only Modrinth projects have a modrinth metadata field for the modrinth.json
             Some(Ok(match project.metadata {
                 crate::prelude::ProjectMetadata::Modrinth {
-                    ref project,
                     ref version,
                     ..
                 } => {
                     let mut env = HashMap::new();
-                    env.insert(EnvType::Client, project.client_side.clone());
-                    env.insert(EnvType::Server, project.server_side.clone());
+                    // TODO: envtype should be a controllable option (in general or at least .mrpack exporting)
+                    // For now, assume required.
+                    // env.insert(EnvType::Client, project.client_side.clone());
+                    // env.insert(EnvType::Server, project.server_side.clone());
+                    env.insert(EnvType::Client, SideType::Required);
+                    env.insert(EnvType::Server, SideType::Required);
 
                     let primary_file = if let Some(primary_file) =
                         version.files.first()
@@ -1037,7 +1056,7 @@ pub async fn create_mrpack_json(
         format_version: 1,
         version_id,
         name: profile.metadata.name.clone(),
-        summary: None,
+        summary: description,
         files,
         dependencies,
     })

theseus/src/api/profile/update.rs

@@ -1,21 +1,22 @@
 use crate::{
     event::{
-        emit::{emit_profile, loading_try_for_each_concurrent},
+        emit::{emit_profile, init_loading, loading_try_for_each_concurrent},
         ProfilePayloadType,
     },
     pack::{self, install_from::generate_pack_from_version_id},
     prelude::{ProfilePathId, ProjectPathId},
     profile::get,
-    state::Project,
-    State,
+    state::{ProfileInstallStage, Project},
+    LoadingBarType, State,
 };
 use futures::try_join;
 
-/// Updates a managed modrinth pack to the cached latest version found in 'modrinth_update_version'
+/// Updates a managed modrinth pack to the version specified by new_version_id
 #[tracing::instrument]
 #[theseus_macros::debug_pin]
-pub async fn update_managed_modrinth(
+pub async fn update_managed_modrinth_version(
     profile_path: &ProfilePathId,
+    new_version_id: &String,
 ) -> crate::Result<()> {
     let profile = get(profile_path, None).await?.ok_or_else(|| {
         crate::ErrorKind::UnmanagedProfileError(profile_path.to_string())
@@ -39,19 +40,14 @@ pub async fn update_managed_modrinth(
     let version_id =
         linked_data.version_id.as_ref().ok_or_else(unmanaged_err)?;
 
-    // extract modrinth_update_version, returning Ok(()) if it is none
-    let modrinth_update_version = match profile.modrinth_update_version {
-        Some(ref x) if x != version_id => x,
-        _ => return Ok(()), // No update version, or no update needed, return Ok(())
-    };
-
     // Replace the pack with the new version
     replace_managed_modrinth(
         profile_path,
         &profile,
         project_id,
         version_id,
-        Some(modrinth_update_version),
+        Some(new_version_id),
+        true, // switching versions should ignore the lock
     )
     .await?;
 
@@ -128,6 +124,7 @@ pub async fn repair_managed_modrinth(
         project_id,
         version_id,
         None,
+        false, // do not ignore lock, as repairing can reset the lock
     )
     .await?;
 
@@ -153,32 +150,61 @@ async fn replace_managed_modrinth(
     project_id: &String,
     version_id: &String,
     new_version_id: Option<&String>,
+    ignore_lock: bool,
 ) -> crate::Result<()> {
+    crate::profile::edit(profile_path, |profile| {
+        profile.install_stage = ProfileInstallStage::Installing;
+        async { Ok(()) }
+    })
+    .await?;
+
     // Fetch .mrpacks for both old and new versions
     // TODO: this will need to be updated if we revert the hacky pack method we needed for compiler speed
-    let old_pack_creator = generate_pack_from_version_id(
-        project_id.clone(),
-        version_id.clone(),
-        profile.metadata.name.clone(),
-        None,
-        profile_path.clone(),
-    );
 
-    // download in parallel, then join. If new_version_id is None, we don't need to download the new pack, so we clone the old one
     let (old_pack_creator, new_pack_creator) =
         if let Some(new_version_id) = new_version_id {
+            let shared_loading_bar = init_loading(
+                LoadingBarType::PackFileDownload {
+                    profile_path: profile_path.get_full_path().await?,
+                    pack_name: profile.metadata.name.clone(),
+                    icon: None,
+                    pack_version: version_id.clone(),
+                },
+                200.0, // These two downloads will share the same loading bar
+                "Downloading pack file",
+            )
+            .await?;
+
+            // download in parallel, then join.
             try_join!(
-                old_pack_creator,
+                generate_pack_from_version_id(
+                    project_id.clone(),
+                    version_id.clone(),
+                    profile.metadata.name.clone(),
+                    None,
+                    profile_path.clone(),
+                    Some(shared_loading_bar.clone())
+                ),
                 generate_pack_from_version_id(
                     project_id.clone(),
                     new_version_id.clone(),
                     profile.metadata.name.clone(),
                     None,
-                    profile_path.clone()
+                    profile_path.clone(),
+                    Some(shared_loading_bar)
                 )
             )?
         } else {
-            let mut old_pack_creator = old_pack_creator.await?;
+            // If new_version_id is None, we don't need to download the new pack, so we clone the old one
+            let mut old_pack_creator = generate_pack_from_version_id(
+                project_id.clone(),
+                version_id.clone(),
+                profile.metadata.name.clone(),
+                None,
+                profile_path.clone(),
+                None,
+            )
+            .await?;
             old_pack_creator.description.existing_loading_bar = None;
             (old_pack_creator.clone(), old_pack_creator)
         };
@@ -197,7 +223,11 @@ async fn replace_managed_modrinth(
     // - install all overrides
     // - edits the profile to update the new data
     // - (functionals almost identically to rteinstalling the pack 'in-place')
-    pack::install_mrpack::install_zipped_mrpack_files(new_pack_creator).await?;
+    pack::install_mrpack::install_zipped_mrpack_files(
+        new_pack_creator,
+        ignore_lock,
+    )
+    .await?;
 
     Ok(())
 }

theseus/src/api/settings.rs

@@ -49,10 +49,19 @@ pub async fn set(settings: Settings) -> crate::Result<()> {
     }
     .await;
 
+    let updated_discord_rpc = {
+        let read = state.settings.read().await;
+        settings.disable_discord_rpc != read.disable_discord_rpc
+    };
+
     {
         *state.settings.write().await = settings;
     }
 
+    if updated_discord_rpc {
+        state.discord_rpc.clear_to_default(true).await?;
+    }
+
     if reset_io {
         state.reset_io_semaphore().await;
     }