tomasalias/AstralRinth
1
0
Fork 0
forked from didirus/AstralRinth
Code Pull Requests Activity

fix(labrinth): make orgs with a single user and only approved projects visible to non-logged-in people (#4557)

Browse Source 
I made a typo on PR https://github.com/modrinth/code/pull/4426 by making
the corresponding SQL query filter by projects with an unexisting
`public` status, instead of `approved`. During my testing, I used the
`archived` status, so I didn't notice it back then.
This commit is contained in:
Alejandro González
2025-10-15 20:16:44 +02:00
committed by GitHub
parent 77afdb1cc4
commit 6dbd1e5236
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
apps/labrinth/.sqlx/query-eb792d5033d7079fe3555593d8731f8853235275e4d5614636b5db524a4920d5.json → apps/labrinth/.sqlx/query-829a4523233e957f8876d248a17ec04c245af41f43fa40aff9ee07e893dabf3a.json generated
View File

@@ -1,6 +1,6 @@
{ {
"db_name": "PostgreSQL", "db_name": "PostgreSQL",
"query": "SELECT TRUE FROM mods WHERE organization_id = $1 AND status IN ('public', 'archived') LIMIT 1", "query": "SELECT TRUE FROM mods WHERE organization_id = $1 AND status IN ('approved', 'archived') LIMIT 1",
"describe": { "describe": {
"columns": [ "columns": [
{ {
@@ -18,5 +18,5 @@
null null
] ]
}, },
"hash": "eb792d5033d7079fe3555593d8731f8853235275e4d5614636b5db524a4920d5" "hash": "829a4523233e957f8876d248a17ec04c245af41f43fa40aff9ee07e893dabf3a"
} }

2
apps/labrinth/src/auth/checks.rs
View File

@@ -377,7 +377,7 @@ pub async fn is_visible_organization(
// This is meant to match the same projects as the `Project::is_searchable` method, but we're not using // This is meant to match the same projects as the `Project::is_searchable` method, but we're not using
// it here because that'd entail pulling in all projects for the organization // it here because that'd entail pulling in all projects for the organization
let has_searchable_projects = sqlx::query_scalar!( let has_searchable_projects = sqlx::query_scalar!(
"SELECT TRUE FROM mods WHERE organization_id = $1 AND status IN ('public', 'archived') LIMIT 1", "SELECT TRUE FROM mods WHERE organization_id = $1 AND status IN ('approved', 'archived') LIMIT 1",
organization.id as database::models::ids::DBOrganizationId organization.id as database::models::ids::DBOrganizationId
) )
.fetch_optional(pool) .fetch_optional(pool)