Misc v3 linear tasks (#767)

* v3_reroute 404 error

* hash change

* fixed issue with error conversion

* added new model confirmation tests
+ title name change

* renaming, fields

* owner; test changes

* clippy prepare

* fmt

* merge fixes

* clippy

* working merge

* revs

* merge fixes

tests/common/api_v2/team.rs

@@ -1,7 +1,10 @@
 use actix_http::StatusCode;
 use actix_web::{dev::ServiceResponse, test};
 use async_trait::async_trait;
-use labrinth::models::teams::{OrganizationPermissions, ProjectPermissions};
+use labrinth::models::{
+    teams::{OrganizationPermissions, ProjectPermissions},
+    v2::{notifications::LegacyNotification, teams::LegacyTeamMember},
+};
 use serde_json::json;
 
 use crate::common::{
@@ -14,6 +17,38 @@ use crate::common::{
 
 use super::ApiV2;
 
+impl ApiV2 {
+    pub async fn get_organization_members_deserialized(
+        &self,
+        id_or_title: &str,
+        pat: &str,
+    ) -> Vec<LegacyTeamMember> {
+        let resp = self.get_organization_members(id_or_title, pat).await;
+        assert_eq!(resp.status(), 200);
+        test::read_body_json(resp).await
+    }
+
+    pub async fn get_team_members_deserialized(
+        &self,
+        team_id: &str,
+        pat: &str,
+    ) -> Vec<LegacyTeamMember> {
+        let resp = self.get_team_members(team_id, pat).await;
+        assert_eq!(resp.status(), 200);
+        test::read_body_json(resp).await
+    }
+
+    pub async fn get_user_notifications_deserialized(
+        &self,
+        user_id: &str,
+        pat: &str,
+    ) -> Vec<LegacyNotification> {
+        let resp = self.get_user_notifications(user_id, pat).await;
+        assert_eq!(resp.status(), 200);
+        test::read_body_json(resp).await
+    }
+}
+
 #[async_trait(?Send)]
 impl ApiTeams for ApiV2 {
     async fn get_team_members(&self, id_or_title: &str, pat: &str) -> ServiceResponse {
@@ -31,6 +66,9 @@ impl ApiTeams for ApiV2 {
     ) -> Vec<CommonTeamMember> {
         let resp = self.get_team_members(id_or_title, pat).await;
         assert_eq!(resp.status(), 200);
+        // TODO: Note, this does NOT deserialize to any other struct first, as currently TeamMember is the same in v2 and v3.
+        // CommonTeamMember = TeamMember (v3)
+        // This may yet change, so we should keep common struct.
         test::read_body_json(resp).await
     }
 
@@ -49,6 +87,9 @@ impl ApiTeams for ApiV2 {
     ) -> Vec<CommonTeamMember> {
         let resp = self.get_project_members(id_or_title, pat).await;
         assert_eq!(resp.status(), 200);
+        // TODO: Note, this does NOT deserialize to any other struct first, as currently TeamMember is the same in v2 and v3.
+        // CommonTeamMember = TeamMember (v3)
+        // This may yet change, so we should keep common struct.
         test::read_body_json(resp).await
     }
 
@@ -67,6 +108,9 @@ impl ApiTeams for ApiV2 {
     ) -> Vec<CommonTeamMember> {
         let resp = self.get_organization_members(id_or_title, pat).await;
         assert_eq!(resp.status(), 200);
+        // TODO: Note, this does NOT deserialize to any other struct first, as currently TeamMember is the same in v2 and v3.
+        // CommonTeamMember = TeamMember (v3)
+        // This may yet change, so we should keep common struct.
         test::read_body_json(resp).await
     }
 
@@ -132,7 +176,11 @@ impl ApiTeams for ApiV2 {
     ) -> Vec<CommonNotification> {
         let resp = self.get_user_notifications(user_id, pat).await;
         assert_status(&resp, StatusCode::OK);
-        test::read_body_json(resp).await
+        // First, deserialize to the non-common format (to test the response is valid for this api version)
+        let v: Vec<LegacyNotification> = test::read_body_json(resp).await;
+        // Then, deserialize to the common format
+        let value = serde_json::to_value(v).unwrap();
+        serde_json::from_value(value).unwrap()
     }
 
     async fn mark_notification_read(&self, notification_id: &str, pat: &str) -> ServiceResponse {