Monorepo missing features (#1273)

* fix tauri config * fix package patch * regen pnpm lock * use new workflow * New GH actions * Update lockfile * update scripts * Fix build script * Fix missing deps * Fix assets eslint * Update libraries lint * Fix all lint configs * update lockfile * add fmt + clippy fails * Separate App Tauri portion * fix app features * Fix lints * install tauri cli * update lockfile * corepack, fix lints * add store path * fix unused import * Fix tests * Issue templates + port over tauri release * fix actions * fix before build command * Add X86 target * Update build matrix * finalize actions * make debug build smaller * Use debug build to make cache smaller * dummy commit * change proj name * update file name * Use release builds for less space use * Remove rust cache * Readd for app build * add merge queue trigger
2024-07-09 15:17:38 -07:00
parent dab284f339
commit d1bc65c266
265 changed files with 1810 additions and 1871 deletions
--- a/packages/app-lib/src/api/logs.rs
+++ b/packages/app-lib/src/api/logs.rs
@@ -114,7 +114,10 @@ pub async fn get_logs_from_type(
        {
            let entry: std::fs::DirEntry =
                entry.map_err(|e| IOError::with_path(e, &logs_folder))?;
-            let age = entry.metadata()?.created().unwrap_or_else(|_| SystemTime::UNIX_EPOCH);
+            let age = entry
+                .metadata()?
+                .created()
+                .unwrap_or(SystemTime::UNIX_EPOCH);
            let path = entry.path();
            if !path.is_file() {
                continue;
@@ -125,7 +128,7 @@ pub async fn get_logs_from_type(
                    Logs::build(
                        log_type,
                        age,
-                        &profile_path,
+                        profile_path,
                        file_name,
                        clear_contents,
                    )
@@ -184,7 +187,7 @@ pub async fn get_logs_by_filename(
    .join(&filename);

    let metadata = std::fs::metadata(&path)?;
-    let age = metadata.created().unwrap_or_else(|_| SystemTime::UNIX_EPOCH);
+    let age = metadata.created().unwrap_or(SystemTime::UNIX_EPOCH);

    Logs::build(log_type, age, &profile_path, filename, Some(true)).await
 }
--- a/packages/app-lib/src/api/pack/import/atlauncher.rs
+++ b/packages/app-lib/src/api/pack/import/atlauncher.rs
@@ -223,9 +223,9 @@ async fn import_atlauncher_unmanaged(
                    && description.version_id.is_some(),
            ),
        });
-        prof.metadata.icon = description.icon.clone();
-        prof.metadata.game_version = game_version.clone();
-        prof.metadata.loader_version = loader_version.clone();
+        prof.metadata.icon.clone_from(&description.icon);
+        prof.metadata.game_version.clone_from(&game_version);
+        prof.metadata.loader_version.clone_from(&loader_version);
        prof.metadata.loader = mod_loader;

        async { Ok(()) }
--- a/packages/app-lib/src/api/pack/import/curseforge.rs
+++ b/packages/app-lib/src/api/pack/import/curseforge.rs
@@ -137,9 +137,9 @@ pub async fn import_curseforge(
                .clone()
                .unwrap_or_else(|| backup_name.to_string());
            prof.install_stage = ProfileInstallStage::PackInstalling;
-            prof.metadata.icon = icon.clone();
-            prof.metadata.game_version = game_version.clone();
-            prof.metadata.loader_version = loader_version.clone();
+            prof.metadata.icon.clone_from(&icon);
+            prof.metadata.game_version.clone_from(&game_version);
+            prof.metadata.loader_version.clone_from(&loader_version);
            prof.metadata.loader = mod_loader;

            async { Ok(()) }
@@ -151,9 +151,10 @@ pub async fn import_curseforge(
            prof.metadata.name = override_title
                .clone()
                .unwrap_or_else(|| backup_name.to_string());
-            prof.metadata.icon = icon.clone();
-            prof.metadata.game_version =
-                minecraft_instance.game_version.clone();
+            prof.metadata.icon.clone_from(&icon);
+            prof.metadata
+                .game_version
+                .clone_from(&minecraft_instance.game_version);
            prof.metadata.loader_version = None;
            prof.metadata.loader = ModLoader::Vanilla;

--- a/packages/app-lib/src/api/pack/import/gdlauncher.rs
+++ b/packages/app-lib/src/api/pack/import/gdlauncher.rs
@@ -90,9 +90,9 @@ pub async fn import_gdlauncher(
            .clone()
            .unwrap_or_else(|| backup_name.to_string());
        prof.install_stage = ProfileInstallStage::PackInstalling;
-        prof.metadata.icon = icon.clone();
-        prof.metadata.game_version = game_version.clone();
-        prof.metadata.loader_version = loader_version.clone();
+        prof.metadata.icon.clone_from(&icon);
+        prof.metadata.game_version.clone_from(&game_version);
+        prof.metadata.loader_version.clone_from(&loader_version);
        prof.metadata.loader = mod_loader;

        async { Ok(()) }
--- a/packages/app-lib/src/api/pack/install_from.rs
+++ b/packages/app-lib/src/api/pack/install_from.rs
@@ -407,9 +407,9 @@ pub async fn set_profile_information(
            None
        };

-        prof.metadata.icon = description.icon.clone();
-        prof.metadata.game_version = game_version.clone();
-        prof.metadata.loader_version = loader_version.clone();
+        prof.metadata.icon.clone_from(&description.icon);
+        prof.metadata.game_version.clone_from(game_version);
+        prof.metadata.loader_version.clone_from(&loader_version);
        prof.metadata.loader = mod_loader;

        async { Ok(()) }
--- a/packages/app-lib/src/api/process.rs
+++ b/packages/app-lib/src/api/process.rs
@@ -18,9 +18,7 @@ pub async fn has_finished_by_uuid(uuid: Uuid) -> crate::Result<bool> {

 // Gets the exit status of a child process stored in the state by UUID
 #[tracing::instrument]
-pub async fn get_exit_status_by_uuid(
-    uuid: Uuid,
-) -> crate::Result<Option<i32>> {
+pub async fn get_exit_status_by_uuid(uuid: Uuid) -> crate::Result<Option<i32>> {
    let state = State::get().await?;
    let children = state.children.read().await;
    children.exit_status(uuid).await
--- a/packages/app-lib/src/launcher/download.rs
+++ b/packages/app-lib/src/launcher/download.rs
@@ -88,7 +88,8 @@ pub async fn download_version_info(
            let partial = d::modded::fetch_partial_version(&loader.url).await?;
            info = d::modded::merge_partial_version(partial, info);
        }
-        info.id = version_id.clone();
+
+        info.id.clone_from(&version_id);

        write(&path, &serde_json::to_vec(&info)?, &st.io_semaphore).await?;
        Ok(info)
--- a/packages/app-lib/src/state/dirs.rs
+++ b/packages/app-lib/src/state/dirs.rs
@@ -165,7 +165,7 @@ impl DirectoryInfo {
    ) -> crate::Result<PathBuf> {
        Ok(profile_id.get_full_path().await?.join("logs"))
    }
-    
+
    /// Gets the crash reports dir for a given profile
    #[inline]
    pub async fn crash_reports_dir(
--- a/packages/app-lib/src/state/minecraft_auth.rs
+++ b/packages/app-lib/src/state/minecraft_auth.rs
@@ -1070,6 +1070,7 @@ fn get_date_header(headers: &HeaderMap) -> DateTime<Utc> {
 }

 #[tracing::instrument]
+#[allow(clippy::format_collect)]
 fn generate_oauth_challenge() -> String {
    let mut rng = rand::thread_rng();

--- a/packages/app-lib/src/state/profiles.rs
+++ b/packages/app-lib/src/state/profiles.rs
@@ -90,7 +90,7 @@ impl ProfilePathId {
    }

    pub async fn profile_path(&self) -> crate::Result<ProfilePathId> {
-        if let Some(p) = crate::profile::get(&self, None).await? {
+        if let Some(p) = crate::profile::get(self, None).await? {
            Ok(p.profile_id())
        } else {
            Err(crate::ErrorKind::UnmanagedProfileError(self.to_string())