Monorepo missing features (#1273)

* fix tauri config

* fix package patch

* regen pnpm lock

* use new workflow

* New GH actions

* Update lockfile

* update scripts

* Fix build script

* Fix missing deps

* Fix assets eslint

* Update libraries lint

* Fix all lint configs

* update lockfile

* add fmt + clippy fails

* Separate App Tauri portion

* fix app features

* Fix lints

* install tauri cli

* update lockfile

* corepack, fix lints

* add store path

* fix unused import

* Fix tests

* Issue templates + port over tauri release

* fix actions

* fix before build command

* Add X86 target

* Update build matrix

* finalize actions

* make debug build smaller

* Use debug build to make cache smaller

* dummy commit

* change proj name

* update file name

* Use release builds for less space use

* Remove rust cache

* Readd for app build

* add merge queue trigger

packages/app-lib/src/api/logs.rs

@@ -114,7 +114,10 @@ pub async fn get_logs_from_type(
         {
             let entry: std::fs::DirEntry =
                 entry.map_err(|e| IOError::with_path(e, &logs_folder))?;
-            let age = entry.metadata()?.created().unwrap_or_else(|_| SystemTime::UNIX_EPOCH);
+            let age = entry
+                .metadata()?
+                .created()
+                .unwrap_or(SystemTime::UNIX_EPOCH);
             let path = entry.path();
             if !path.is_file() {
                 continue;
@@ -125,7 +128,7 @@ pub async fn get_logs_from_type(
                     Logs::build(
                         log_type,
                         age,
-                        &profile_path,
+                        profile_path,
                         file_name,
                         clear_contents,
                     )
@@ -184,7 +187,7 @@ pub async fn get_logs_by_filename(
     .join(&filename);
 
     let metadata = std::fs::metadata(&path)?;
-    let age = metadata.created().unwrap_or_else(|_| SystemTime::UNIX_EPOCH);
+    let age = metadata.created().unwrap_or(SystemTime::UNIX_EPOCH);
 
     Logs::build(log_type, age, &profile_path, filename, Some(true)).await
 }

packages/app-lib/src/api/pack/import/atlauncher.rs

@@ -223,9 +223,9 @@ async fn import_atlauncher_unmanaged(
                     && description.version_id.is_some(),
             ),
         });
-        prof.metadata.icon = description.icon.clone();
-        prof.metadata.game_version = game_version.clone();
-        prof.metadata.loader_version = loader_version.clone();
+        prof.metadata.icon.clone_from(&description.icon);
+        prof.metadata.game_version.clone_from(&game_version);
+        prof.metadata.loader_version.clone_from(&loader_version);
         prof.metadata.loader = mod_loader;
 
         async { Ok(()) }

packages/app-lib/src/api/pack/import/curseforge.rs

@@ -137,9 +137,9 @@ pub async fn import_curseforge(
                 .clone()
                 .unwrap_or_else(|| backup_name.to_string());
             prof.install_stage = ProfileInstallStage::PackInstalling;
-            prof.metadata.icon = icon.clone();
-            prof.metadata.game_version = game_version.clone();
-            prof.metadata.loader_version = loader_version.clone();
+            prof.metadata.icon.clone_from(&icon);
+            prof.metadata.game_version.clone_from(&game_version);
+            prof.metadata.loader_version.clone_from(&loader_version);
             prof.metadata.loader = mod_loader;
 
             async { Ok(()) }
@@ -151,9 +151,10 @@ pub async fn import_curseforge(
             prof.metadata.name = override_title
                 .clone()
                 .unwrap_or_else(|| backup_name.to_string());
-            prof.metadata.icon = icon.clone();
-            prof.metadata.game_version =
-                minecraft_instance.game_version.clone();
+            prof.metadata.icon.clone_from(&icon);
+            prof.metadata
+                .game_version
+                .clone_from(&minecraft_instance.game_version);
             prof.metadata.loader_version = None;
             prof.metadata.loader = ModLoader::Vanilla;
 

packages/app-lib/src/api/pack/import/gdlauncher.rs

@@ -90,9 +90,9 @@ pub async fn import_gdlauncher(
             .clone()
             .unwrap_or_else(|| backup_name.to_string());
         prof.install_stage = ProfileInstallStage::PackInstalling;
-        prof.metadata.icon = icon.clone();
-        prof.metadata.game_version = game_version.clone();
-        prof.metadata.loader_version = loader_version.clone();
+        prof.metadata.icon.clone_from(&icon);
+        prof.metadata.game_version.clone_from(&game_version);
+        prof.metadata.loader_version.clone_from(&loader_version);
         prof.metadata.loader = mod_loader;
 
         async { Ok(()) }

packages/app-lib/src/api/pack/install_from.rs

@@ -407,9 +407,9 @@ pub async fn set_profile_information(
             None
         };
 
-        prof.metadata.icon = description.icon.clone();
-        prof.metadata.game_version = game_version.clone();
-        prof.metadata.loader_version = loader_version.clone();
+        prof.metadata.icon.clone_from(&description.icon);
+        prof.metadata.game_version.clone_from(game_version);
+        prof.metadata.loader_version.clone_from(&loader_version);
         prof.metadata.loader = mod_loader;
 
         async { Ok(()) }

packages/app-lib/src/api/process.rs

@@ -18,9 +18,7 @@ pub async fn has_finished_by_uuid(uuid: Uuid) -> crate::Result<bool> {
 
 // Gets the exit status of a child process stored in the state by UUID
 #[tracing::instrument]
-pub async fn get_exit_status_by_uuid(
-    uuid: Uuid,
-) -> crate::Result<Option<i32>> {
+pub async fn get_exit_status_by_uuid(uuid: Uuid) -> crate::Result<Option<i32>> {
     let state = State::get().await?;
     let children = state.children.read().await;
     children.exit_status(uuid).await