fix: incorrectly showing empty state for versions page (#6303)

* fix: incorrectly showing empty state for versions page

* refactor: pnpm prepr
This commit is contained in:
Truman Gao
2026-06-08 10:40:00 -06:00
committed by GitHub
parent 4d654162eb
commit 97a8c11b50
3 changed files with 12 additions and 4 deletions
@@ -1898,6 +1898,7 @@ const versions = computed(() => {
// Versions loading state
const versionsLoading = computed(() => versionsV3Loading.value)
const versionsLoaded = computed(() => versionsV3.value !== undefined || !!_versionsV3Error.value)
// Load versions on demand (client-side only)
function loadVersions() {
@@ -2741,6 +2742,7 @@ provideProjectPageContext({
// Lazy version loading
versions,
versionsLoading,
versionsLoaded,
// Lazy dependencies loading
dependencies,
dependenciesLoading: computed(() => dependenciesLoading.value),
@@ -1,10 +1,7 @@
<template>
<section class="overflow-visible">
<!-- Loading state -->
<div
v-if="versionsLoading && !versions?.length"
class="flex items-center justify-center gap-2 py-8"
>
<div v-if="showVersionsLoadingState" class="flex items-center justify-center gap-2 py-8">
<SpinnerIcon class="animate-spin" />
<span>Loading versions...</span>
</div>
@@ -291,10 +288,18 @@ const {
invalidate,
versions,
versionsLoading,
versionsLoaded,
loadVersions,
cdnDownloadReason,
} = injectProjectPageContext()
const showVersionsLoadingState = computed(
() =>
!versions.value?.length &&
(versionsLoading.value ||
(!versionsLoaded.value && (project.value?.versions?.length ?? 0) > 0)),
)
// Load versions on mount (client-side)
onMounted(() => {
loadVersions()
@@ -17,6 +17,7 @@ export interface ProjectPageContext {
// Lazy version loading (client-side only)
versions: Ref<Labrinth.Versions.v2.Version[] | null>
versionsLoading: Ref<boolean>
versionsLoaded: Ref<boolean>
// Lazy dependencies loading (client-side only)
dependencies: Ref<Labrinth.Projects.v2.DependencyInfo | null>
dependenciesLoading: Ref<boolean>